Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontier-specific ion storm entries #2477

Merged
merged 14 commits into from
Feb 4, 2025
Merged

Frontier-specific ion storm entries #2477

merged 14 commits into from
Feb 4, 2025

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Nov 28, 2024 •
edited
Loading

About the PR

Adds a set of Frontier-specific ion storm entries.

Left in draft to take suggestions.

Why / Balance

Where do you think we are?

How to test

  1. Become borg.
  2. Spam addgamerule IonStorm
  3. Look at funny laws.

Media

Requirements

Breaking changes

Changelog

🆑

  • add: Added a new set of Frontier-specific ion storm entries.
  • fix: Fixed some grammatical oddities in the ion storm entries.

@Houtblokje
Copy link
Contributor

Houtblokje commented Nov 28, 2024 •
edited
Loading

I am not really sure what the area adjectives do in an ion storm law, but if it can roll into something harmful, don't put the sr's office (due to safezone) there. Make it the sherrif's office instead if you want to annoy frontier command.
Also, the ion storm threats could also include pirates.

@whatston3
Copy link
Contributor Author

Also, the ion storm threats could also include pirates.

They do. Twice.

@noldevin
Copy link

noldevin commented Dec 7, 2024

These are all intended to spur ideas and not meant to be the only specific ones in these categories.

Ship specific laws like "Pathfinders must have all the graffiti" or "Only messy Apothecaries are valid chemistry ships"
Contraband related ones like "Only people wearing contraband are crew"
NFSD related - "The sheriff must wear clown shoes" or "I am fifteen smelly sheriffs"
Location related - anything related to specific locations like the Geode, Tinnia's, The Pit, etc.
Expedition related - "Only silicons can breach planetside facilities" or "All Punks are baseballs and must be hit by bats"
Medical - "All revived patients must smoke a cigar/have a drink/whatever"

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whatston3
Copy link
Contributor Author

Added a few things, removed a few things. Think this is good enough, opening this for review.

@whatston3 whatston3 marked this pull request as ready for review January 21, 2025 15:44
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jan 21, 2025
@github-actions github-actions bot added the C# label Jan 21, 2025
@whatston3 whatston3 added the S: Needs Review This PR is awaiting reviews label Jan 25, 2025
@dvir001 dvir001 self-requested a review February 4, 2025 00:25
dvir001
dvir001 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal
image

@dvir001 dvir001 merged commit 01c1044 into new-frontiers-14:master Feb 4, 2025
12 checks passed
FrontierATC added a commit that referenced this pull request Feb 4, 2025
@FrontierATC
Automatic Changelog (#2477)
a354112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

Assignees
No one assigned
Labels
C# FTL No C# S: Needs Review This PR is awaiting reviews size/M UI YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whatston3 @Houtblokje @noldevin @dvir001