Fix more integration tests

Content.IntegrationTests/Tests/EntityTest.cs

@@ -19,7 +19,6 @@ public sealed class EntityTest
         private static readonly ProtoId<EntityCategoryPrototype> SpawnerCategory = "Spawner";
 
         [Test]
-        [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - unsure which entities are currently failing
         public async Task SpawnAndDeleteAllEntitiesOnDifferentMaps()
         {
             // This test dirties the pair as it simply deletes ALL entities when done. Overhead of restarting the round
@@ -82,7 +81,6 @@ await server.WaitPost(() =>
         }
 
         [Test]
-        [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - unsure which entities are currently failing
         public async Task SpawnAndDeleteAllEntitiesInTheSameSpot()
         {
             // This test dirties the pair as it simply deletes ALL entities when done. Overhead of restarting the round
@@ -141,7 +139,6 @@ await server.WaitPost(() =>
         ///     all components on every entity.
         /// </summary>
         [Test]
-        [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - unsure which entities are currently failing
         public async Task SpawnAndDirtyAllEntities()
         {
             // This test dirties the pair as it simply deletes ALL entities when done. Overhead of restarting the round
@@ -227,7 +224,6 @@ await server.WaitPost(() =>
         /// crude test to try catch issues like this, and possibly should just be disabled.
         /// </remarks>
         [Test]
-        [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - unsure which entities are currently failing
         public async Task SpawnAndDeleteEntityCountTest()
         {
             var settings = new PoolSettings { Connected = true, Dirty = true };
@@ -241,6 +237,7 @@ public async Task SpawnAndDeleteEntityCountTest()
                 "MapGrid",
                 "StationEvent",
                 "TimedDespawn",
+                "TransferMindOnDespawnComponent", // Frontier
 
                 // makes an announcement on mapInit.
                 "AnnounceOnSpawn",

Content.IntegrationTests/Tests/Internals/AutoInternalsTests.cs

@@ -9,7 +9,8 @@ namespace Content.IntegrationTests.Tests.Internals;
 [TestOf(typeof(InternalsSystem))]
 public sealed class AutoInternalsTests
 {
-    [Ignore("Not relevant for Frontier")] // Frontier
+    [Test]
+    [Ignore("Preventing CI tests from failing")] // Frontier: FIXME
     public async Task TestInternalsAutoActivateInSpaceForStationSpawn()
     {
         await using var pair = await PoolManager.GetServerClient();
@@ -35,7 +36,8 @@ await server.WaitAssertion(() =>
         await pair.CleanReturnAsync();
     }
 
-    [Ignore("Not relevant for Frontier")] // Frontier
+    [Test]
+    [Ignore("Preventing CI tests from failing")] // Frontier: FIXME
     public async Task TestInternalsAutoActivateInSpaceForEntitySpawn()
     {
         await using var pair = await PoolManager.GetServerClient();

Content.IntegrationTests/Tests/Storage/StorageInteractionTest.cs

@@ -17,7 +17,7 @@ public sealed class StorageInteractionTest : InteractionTest
     /// Check that players can interact with items in storage if the storage UI is open
     /// </summary>
     [Test]
-    [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - no idea what's actually causing a failure here.
+    [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - no idea what's actually causing a failure here..
     public async Task UiInteractTest()
     {
         var sys = Server.System<SharedContainerSystem>();

Content.IntegrationTests/Tests/UserInterface/UiControlTest.cs

@@ -22,7 +22,6 @@ public sealed class UiControlTest
     /// Tests that all windows can be instantiated successfully.
     /// </summary>
     [Test]
-    [Ignore("Preventing CI tests from failing")] // Frontier: FIXME - bad Cryosleep UI registration
     public async Task TestWindows()
     {
         var pair = await PoolManager.GetServerClient(new PoolSettings()

Content.Server/Weapons/Ranged/Systems/GunSystem.cs

@@ -162,6 +162,11 @@ public override void Shoot(EntityUid gunUid, GunComponent gun, List<(EntityUid?
                     var fromEffect = fromCoordinates;
                     var dir = mapDirection.Normalized();
 
+                    // Frontier: if direction isn't near one (standing on top of target), default to a given direction
+                    if (!MathHelper.CloseToPercent(dir.LengthSquared(), 1))
+                        dir = new Vector2(1, 0);
+                    // End Frontier
+
                     //in the situation when user == null, means that the cannon fires on its own (via signals). And we need the gun to not fire by itself in this case
                     var lastUser = user ?? gunUid;
 

Content.Server/_NF/Explosion/Components/TriggerOnProjectileHitComponent.cs

@@ -4,4 +4,6 @@ namespace Content.Server.Explosion.Components;
 /// Frontier: Triggers on the entity hitting something else as a projectile.
 /// </summary>
 [RegisterComponent]
-public sealed partial class TriggerOnProjectileHitComponent : Component;
+public sealed partial class TriggerOnProjectileHitComponent : Component
+{
+}

Content.Shared/Mobs/Systems/MobThresholdSystem.cs

@@ -168,7 +168,7 @@ public bool TryGetIncapThreshold(EntityUid target, [NotNullWhen(true)] out Fixed
         MobThresholdsComponent? thresholdComponent = null)
     {
         threshold = null;
-        if (!Resolve(target, ref thresholdComponent))
+        if (!Resolve(target, ref thresholdComponent, logMissing: false)) // Frontier: set logMissing to false
             return false;
 
         return TryGetThresholdForState(target, MobState.Critical, out threshold, thresholdComponent)

Resources/Prototypes/Loadouts/loadout_groups.yml

@@ -1318,7 +1318,7 @@
 - type: loadoutGroup
   id: SurvivalSyndicate
   name: loadout-group-survival-syndicate
-  minLimit: 2
+  minLimit: 1 # Frontier: 2<1 - test failures, getting two boxes
   hidden: true
   loadouts:
   - EmergencyNitrogenSyndicate

Resources/Prototypes/_NF/Entities/Structures/Storage/Crates/base_structurecrates.yml

@@ -1,6 +1,7 @@
 - type: entity
   parent: [BaseStructureLockImmuneToEmag, BaseStructureAccessReaderImmuneToEmag, CrateBaseWeldable]
   id: CrateTradeBaseSecure
+  abstract: true
   categories: [ HideSpawnMenu ]
   components:
   - type: TradeCrate