-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comet Defib Update #2690
base: master
Are you sure you want to change the base?
Comet Defib Update #2690
Conversation
- Cutting back on a few luxuries to maintain the shuttle's price.
Pulled it to have a walk around. There is a lot of love put into this revamp and it shows immediately. From small things like the attention and details put into the new crew living space, to the hazard lights that strobe when the cargo blast doors are open. My only critical feedback would be that the light switch in the "smuggling area" wall does make it clear there is a fake wall there. I'm not sure how to fix this without compromising the smuggling areas aesthetic. Maybe just ditch the hidden door since most folks know it's there anyway, and leave it as a viewing deck? Unsure. Very minor point either way, and I can see myself using the Comet a lot with a crew in the future. |
I feel you. Wall placement visibility remains a trial and an annoyance. On one hand the Comet's smuggling deck is about as much of a secret as my user name. On the other hand, uh, yeah visuals are annoying. Dang has it really been over half a month since I submitted this? |
If you want to smuggle, just deconstruct the lightswitch? |
If you want to smuggle don't buy a Comet. Not that anyone will ever buy a Comet ever again. Anyways the holopad is updated. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…-station-14 into Comet-Defib-Update
Ran through the merge conflict - things seem okay, but do give them another look when you can, and do map a black deck box instead of the deck of cards. Thanks! |
Let's [DO NOT MAP] the inappropriate deck to prevent issues down the road? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ha, cards |
…-station-14 into Comet-Defib-Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look through this, seems good on the whole.
Wiring looks good, atmos setup makes sense to my eyes, nicely sectioned, devices seem linked well. There seem to be a lot of mapped gubbins on tables and the like, but with the exceptions of maybe the QM's locker and the materials locker (and even then, comparable to the CE locker/suit storage and loose materials mapped previously), nothing seems overtly questionable.
Ship looks nice, good decal work on the floors, and the buttons do some neat things.
Spin me right round Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
like a record Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving, requested changes made.
About the PR
Ship owner: @Shodhans
Just tagging you to make sure you're aware there's proposed changes on your ship. I made a few changes that differentiate from the original layout so I want to make sure that you're comfortable with them.
"[7:37 PM]Recluse (Marty Sevenn): in that case yeah no worries at all, full speed ahead"
Original author says good to go. Always important!
Claire Vallis, I believe, over on Discord raised the flag of the Comet missing a defib. A discussion emerged regarding the AME over producing power and some other elements with the shuttle having a few pieces that could use some up to date passes.
Major changes:
Secondary changes:
Tertiary changes:
Equipment changes:
Oh and also I added the requested defib.
If this PR seems acceptable I can submit an updated map for the guidebook as well.
Why / Balance
Defibs are good.
How to test
Buy the ship. Push the buttons.
Media
Requirements
Breaking changes
Changelog
🆑