-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds casks to the service techfab #2842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
whatston3
reviewed
Feb 4, 2025
I have no idea about a category. It could work. But that might demand a more robust re-organization? It certainly wouldn't just be a trio of casks. |
whatston3
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright.
whatston3
approved these changes
Feb 5, 2025
FrontierATC
added a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds the plastic, steel and wood casks to the service techfab.
It also changes the naming conventions for those casks. Removing the suffix and instead simply naming them wood/plastic/steel for ease of use and recognition outside of the spawn menu context.
Why / Balance
These are useful tools.
I placed the crafting cost at 250, using the bucket as a guide. The bucket clocks in at 200 material per, with the 50 material tax for the lid. Given that they have equivalent storage. If one of those elements changes in the future the crafting cost can be revised.
How to test
Print casks, use casks.
Media
Requirements
Breaking changes
Changelog
🆑