Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds casks to the service techfab #2842

Merged
merged 11 commits into from
Feb 8, 2025
Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Feb 2, 2025

About the PR

This PR adds the plastic, steel and wood casks to the service techfab.

It also changes the naming conventions for those casks. Removing the suffix and instead simply naming them wood/plastic/steel for ease of use and recognition outside of the spawn menu context.

Why / Balance

These are useful tools.

I placed the crafting cost at 250, using the bucket as a guide. The bucket clocks in at 200 material per, with the 50 material tax for the lid. Given that they have equivalent storage. If one of those elements changes in the future the crafting cost can be revised.

How to test

Print casks, use casks.

Media

ss+(2025-02-02+at+09 42 18)

Requirements

Breaking changes

Changelog

🆑

  • add: Plastic, steel and wood casks to service techfab. Edit capacity to 300u for future brewing recipe consistency.

Copy link
Contributor

github-actions bot commented Feb 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Feb 2, 2025
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Feb 2, 2025
@whatston3 whatston3 added S: Needs Review This PR is awaiting reviews and removed S: Untriaged labels Feb 4, 2025
@dustylens
Copy link
Contributor Author

I have no idea about a category.

It could work. But that might demand a more robust re-organization? It certainly wouldn't just be a trio of casks.

@github-actions github-actions bot added the FTL label Feb 5, 2025
@whatston3 whatston3 added S: Approved and removed S: Needs Review This PR is awaiting reviews labels Feb 5, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright.

@dvir001 dvir001 merged commit 5d4ac65 into new-frontiers-14:master Feb 8, 2025
13 checks passed
FrontierATC added a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants