Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static physics for Frontier grids #2848

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Feb 3, 2025

About the PR

Sets most Frontier stations and POI grids to static bodies.

Adds a new component, ForceAnchorComponent, that, when placed on an entity that initializes, sets the physics status of the entity to Static and OnGround. This results in easier physical simulation. It also adds another new component, PreventGridAnchorChangesComponent, which prevents station anchors from changing a grid's anchored status.

Why / Balance

Physics bad. Less physics good.

Should result in less unpredictable jank through massive physics parameters (ships getting massive impulses when bonking the station slightly)

How to test

  1. Spawn in-game.
  2. Check the PhysicsComponent on Frontier Outpost. It should be OnGround and Static. Check the ShuttleComponent, it should be disabled.
  3. Check the PhysicsComponent on the NFSD Outpost. It should be OnGround and Static. Check the ShuttleComponent, it should be disabled.
  4. Run addgamerule BluespaceCave. Wait for the cave to appear.
  5. Check the PhysicsComponent on the Cave, it should be OnGround and Static. Check the ShuttleComponent, it should be disabled.
  6. Add a station anchor [On] to the cave. Turn it off. Check the Physics and ShuttleComponents on the Cave, there should be no changes.
  7. Repeat step 6 for the Frontier Outpost.
  8. Repeat step 6 for the NFSD Outpost.
  9. Purchase a Pioneer at Frontier Outpost.
  10. Repeat step 6 for the pioneer. When the station anchor is on, it should be immobile, and when it is off, it should be able to move.
  11. Repeat step 6 on the Public Transit Shuttle, then turn it back on. The shuttle should remain InAir and Dynamic regardless of the anchor's state.

Media

this guy

Requirements

Breaking changes

Changelog

🆑

  • fix: Immobile stations should have fewer issues with physics simulation.

@whatston3 whatston3 added S: Needs Review This PR is awaiting reviews and removed S: Untriaged labels Feb 3, 2025
@github-actions github-actions bot added the Map-Shuttle Map - Shuttle label Feb 3, 2025
@dvir001 dvir001 self-requested a review February 3, 2025 12:33
@whatston3
Copy link
Contributor Author

Should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Outpost Map - Outpost Map-POI Map - POI Map-Shuttle Map - Shuttle S: Needs Review This PR is awaiting reviews size/M YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants