Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterBorg Hotfix: Unremoveable after equip #2854

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

When re-equipping items from a borg's provided item container:

  1. If the item is an actual item, equip it as usual.
  2. If the item is a placeholder, create a hand, equip it, make sure it's equipped, and if so, you're fine.
  3. If the item equipped is not your item (e.g. an empty hand), delete the hand. No free hands, ever.

Why / Balance

I goofed.

How to test

  1. Become service borg
  2. Swap to your service module.
  3. Drop your borg shaker and borg lighter.
  4. Unequip the service module, re-equip the service module.
  5. Your shaker and lighter placeholder items should still exist in your hands.

Media

The book bag and shaker here are unequipped, placeholder items.
image

Requirements

Breaking changes

Changelog

Not in-game yet.

@whatston3 whatston3 requested a review from dvir001 February 4, 2025 03:32
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Feb 4, 2025
@dvir001 dvir001 merged commit c1dc8d9 into new-frontiers-14:master Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants