Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Module and Cyborg Action Icons for Our Modules #2857

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

Myzumi
Copy link
Contributor

@Myzumi Myzumi commented Feb 4, 2025

About the PR

Baiscly #2751 without the Port.

Adds in a Cyborg Jetpack Module, Removes Space Drifting for Cyborgs (Basic Jetpack Flight) and adds in the Missing Action Sprites made by GhostPrince

Changes from Original PR;

  • Jetpack Sprite has been changed to an gray one;
  • Removed Porting Contents;

Why / Balance

Borgs should have jetpacks.

How to test

  • Spawn Borg
  • Slam Jetpack Module in Borg
  • See new Action Icon, Click it in Space
  • Explore the Outer Space

Media

Requirements

Breaking changes

Changelog

🆑

  • add: A new printable module is available for cyborgs with a jetpack inside.
  • fix: The Advanced Mining and Paramedic modules now have action icons.
  • remove: Cyborgs are no longer able to fly through space on their own.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

RSI Diff Bot; head commit 700140b merging into 3222bf6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Interface/Actions/actions_borg.rsi

State Old New Status
adv-drill-module Added
adv-paramed-module Added
jetpack-module Added

Resources/Textures/_NF/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-jetpack Added

Edit: diff updated after 700140b

@github-actions github-actions bot added the size/S label Feb 4, 2025
@github-actions github-actions bot added the C# label Feb 4, 2025
@whatston3
Copy link
Contributor

Changelog touched up, blood-red magboots no longer fit in the cyborg jetpack slot.
I opted to use a new NF-specific parent for the jetpack. Might be cleaner to just toss the components in the individual jetpacks, there aren't that many of them.

Works fine under test.

@whatston3
Copy link
Contributor

whatston3 commented Feb 4, 2025

Just jotting down thoughts here:
It might be worth adding the GPS/mass scanner components to that jetpack module.
Even removing the base GPS module would be fine because it isn't really useful [on its own, without a means of propulsion].
Fire extinguisher is a meme, there aren't many fires, but fine.

@github-actions github-actions bot added the No C# label Feb 4, 2025
@whatston3 whatston3 removed the C# label Feb 4, 2025
…rg_modules.yml

Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com>
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving, reverted the change that reparented jetpacks to avoid matching with the syndie magboots, it was deemed more complex than needed. Seemed acceptable during testing, should be good to go.

@dvir001 dvir001 self-requested a review February 5, 2025 19:12
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Feb 5, 2025
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the base jetpack removed but overall this is ok as an upgrade.

@dvir001 dvir001 merged commit c9f6d40 into new-frontiers-14:master Feb 5, 2025
16 checks passed
FrontierATC added a commit that referenced this pull request Feb 5, 2025
@whatston3
Copy link
Contributor

whatston3 commented Feb 5, 2025

Not a fan of the base jetpack removed but overall this is ok as an upgrade.

Better solution is to put the module in (most? all?) borg chassis on selection and consolidate its features against the GPS/navigation module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants