Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contraband and medical price scanners beep #2859

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

The medical and contraband price guns now beep, consistent with the base appraisal tool.

The API of both was swapped out from EntityUid, Component to Entity.

Why / Balance

Consistency.

How to test

  1. Scan yourself with the contraband tool. Beep. Message should be accurate.
  2. Spawn and scan a blood red hardsuit with the contraband tool. Beep. Message should be accurate.
  3. Scan yourself with the medical bounty scanner. Beep. Message should be accurate.
  4. Spawn an emergency medical pod, scan the occupant. Beep. Message should be accurate.

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Contraband and medical bounty scanners should now beep when used.

@whatston3 whatston3 added S: Needs Review This PR is awaiting reviews and removed S: Untriaged labels Feb 5, 2025
@dvir001 dvir001 self-requested a review February 5, 2025 16:45
@dvir001 dvir001 added S: Approved and removed S: Needs Review This PR is awaiting reviews labels Feb 5, 2025
@dvir001 dvir001 merged commit ee1f826 into new-frontiers-14:master Feb 5, 2025
15 checks passed
FrontierATC added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants