Backport Goob/EE playing card fixes (Goob#1215 and #1311 via EE#1451) #2861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Backports Goob#1215 and Goob#1311 via EE#1451.
Many thanks to @RadsammyT and @VMSolidus for the work in improving and cleaning up this feature.
Brings over definitions for Nanotrasen and Syndicate branded cards, decks and boxes, along with an uplink listing. If these are deemed bloat, they can be removed.
Cards in a user's inventory are hidden from the strip menu. The component for this, StripMenuHiddenComponent, seems interesting - it's been namespaced appropriately, and changes to the strip menu have been commented.
Still think that the use key should flip a hand of cards when in-hand as it does for a single one.
Why / Balance
It's nice to backport fixes.
How to test
Very carefully. Play some cards, try to cheat, fail miserably.
Media
The picture below shows the three deck boxes in-game, the fronts and backs of the first few cards of unshuffled decks.
![image](https://private-user-images.githubusercontent.com/166147148/409821871-9ba1ed40-90c5-4234-8a8d-63c94746cb04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjUzNzgsIm5iZiI6MTczODg2NTA3OCwicGF0aCI6Ii8xNjYxNDcxNDgvNDA5ODIxODcxLTliYTFlZDQwLTkwYzUtNDIzNC04YThkLTYzYzk0NzQ2Y2IwNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxODA0MzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04MmE2MDMzZGQ2ZWNkMjQ5YzI4ZDRhNjc3ODViODJmYzEwODdkY2IyNjRhZTZjNjVjZjNkYjM1MzkyYzdhMDAwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xeNMQDrBUv16glcPYsN0_5OHblwGHiM1tVkANIK05Kw)
Requirements
Breaking changes
Changelog
🆑 RadsammyT and VMSolidus