Silence reagent dispensers on spawn. #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatston3
added
S: Needs Review
|
Not a fan of this one. |
dvir001
approved these changes
Feb 5, 2025
FrontierATC
added a commit
that referenced
this pull request
Feb 5, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Feb 24, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Feb 24, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 1, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 1, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 3, 2025
percent-temp-percent
pushed a commit
to Corvax-Frontier/Frontier
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Calls ContainerSystem.Insert directly instead of ItemSlot.Insert when initializing a reagent dispenser.
Why / Balance
Currently, the reagent dispenser plays the clicky insert sound when inserting things into the dispenser. It does this for each item in the dispenser on spawn. If you warp to a chemistry ship, your ears currently bleed.
How to test
Media
The contents of a chemical dispenser after spawning. Everything is accounted for.
Requirements
Breaking changes
Changelog
🆑