Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pirate Shuttles, Pirate Cove: pirate-locked doors #2893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Feb 9, 2025

About the PR

Introduces a new access for pirates. Locks pirate shuttle doors behind pirate access. All doors on the cove apart from the freezer and bathroom doors are Pirate access-locked. Pirates, Pirate First Mates (this includes Clarpy), and Pirate Captains all receive the Pirate access.

Aghosts receive this access level, as well as the universal configurator having it.

Note: the two NFSD ships that currently have unlocked docking airlocks are the Templar and the Hospitaller. Unsure of the best course, I have left those as-is for the time being.

Why / Balance

The sheriff now has disposable access configurators. This PR ensures that the NFSD cannot break into the Pirate Cove or pirate shuttles, or lock access to them by simply opening or reconfiguring the doors. Get an ID card off of a pirate.

Why a new access level?

  1. Pirates shouldn't have syndicate access - LPBravo and the drop pods should still be locked to pirates.
  2. Pirates shouldn't have nuclear operative access - this is used for trade crates.

Why lock these at all?
Symmetry and consistency. Now each side's ships are locked against members of the other faction.

How to test

  1. Spawn as each pirate role on the cove. Open the airlocks and hatches, you should be able to.
  2. Purchase each shuttle, confirm that the doors are pirate access-locked.
  3. Aghost, open the pirate-locked doors, you should be able to.

Media

The access configurator window shown trying to edit the eastern hatch to the Pirate Cove with a sheriff's ID card. No dice this time.
image

Requirements

Breaking changes

Changelog

🆑

  • add: Pirate shuttles and the cove now have locked doors. Only pirates currently have access to these doors.

@Houtblokje
Copy link
Contributor

I wonder if pirate captains should get their own access configurator to set the access for doors, in case they want to change their ship layout or steal/buy a regular civilian ship.
But that could and should probably be done/discussed in another PR.

@dvir001
Copy link
Contributor

dvir001 commented Feb 11, 2025

This also fixed the Sheriff door remote able to fuck with pirates

@dvir001 dvir001 self-requested a review February 11, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL Map-POI Map - POI Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews size/M YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants