Fix MaterialStorageMagnetPickup material duplication #2899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
What it says on the tin.
Calls Del over QueueDel when inserting materials into material storage. Our MaterialStorageMagnetPickup doesn't account for duplication, relying on TryInsertMaterialEntity. Problem is that it queues the entity for deletion, which'll happen before the next tick, but after other lathes check their magnets.
Why / Balance
Bug report here: https://discord.com/channels/1123826877245694004/1338300489481326593
How to test
Media
Requirements
Breaking changes
Changelog
No real in-game effect outside of abuse prevention, no changelog this time.