Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add holopad flatpack, hand labeller to all pirate ships #2901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alkheemist
Copy link
Contributor

About the PR

Adds a holopad flatpack and a hand labeller to all pirate ships. Sometimes also adds a rack underneath them if it makes sense in the context.

Why / Balance

So pirates can get holopads without needing to ahelp.

How to test

  • Spawn the ships
  • Look at the ships

Media

Requirements

Breaking changes

N/A

Changelog

🆑

  • add: Added holopad flatpacks to pirate ships.

@dvir001
Copy link
Contributor

dvir001 commented Feb 11, 2025

Why not just map them?

@arimah
Copy link
Contributor

arimah commented Feb 11, 2025

Why not just map them?

They start out turned on and visible, which kind of ruins pirates' ability to be stealthy. That's why we didn't map them in the first place, until we have a better option.

@dvir001
Copy link
Contributor

dvir001 commented Feb 11, 2025

Why not just map them?

They start out turned on and visible, which kind of ruins pirates' ability to be stealthy. That's why we didn't map them in the first place, until we have a better option.

In this case this is the right code fix then, add a version for pirates.

@Houtblokje
Copy link
Contributor

Why not just map them?

They start out turned on and visible, which kind of ruins pirates' ability to be stealthy. That's why we didn't map them in the first place, until we have a better option.

Does it not just take the name of the ship? So the only ship that gets ruined is the schooner, because its the only ship that does not take the name of a civilian ship?

@whatston3
Copy link
Contributor

At minimum, could you create an antag version that, to start, doesn't take the ship's ID and map that instead?

I would prefer to have a solution for antagonists that:

  1. optionally leaves your holopad unlisted - there should be a checkbox in the UI to set this
  2. sends colour information to receivers so you can appear as blue/red/yellow on the receiver's side (should be tied to the sending holopad)
  3. optionally switches between an identity masking hologram (looks like corrupted data, squares or some such) and adds a voicemask to the holopad itself - another checkbox, and this one might want to be changed in-call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants