Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator: check entry type through substring matching #202

Merged
merged 3 commits into from
Aug 9, 2024
Merged

validator: check entry type through substring matching #202

merged 3 commits into from
Aug 9, 2024

Conversation

nadiamoe
Copy link
Contributor

@nadiamoe nadiamoe commented Aug 5, 2024

Markdown validator tripped on me when using Enhancements (plural). As the render action outputs it in plural form, it only makes sense for the validator to also accept it in plural form.

Closes #130

@nadiamoe nadiamoe requested a review from a team August 5, 2024 20:09
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kilokang
kilokang approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@kilokang kilokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this :D

@kilokang kilokang merged commit 555a2d2 into newrelic:main Aug 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilokang kilokang kilokang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator is so strict with changelog
3 participants
@nadiamoe @CLAassistant @kilokang