Increase minimum LibsshSession timeout #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the timeout is set to 1 in LibsshSession(timeout=1), pylibssh
no longer returns an exception for a wrong password SSH connect()
with pytest.raises(SSHAuthenticationError):
client.ssh("user1", "Wrong").connect()
Increase the minimum timeout a couple seconds here.
Regarding 'LibsshSession(timeout=1)', a very low value must be set
here, to allow the timeout set in
client.host.conn.run(..., timeout=X)
to work as expected. This is due to code becoming blocked in libssh
which is C not Python, but the Python signal is delayed until we get
back to the Python code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the timeout is set to 1 in LibsshSession(timeout=1), pylibssh no longer returns an exception for a wrong password SSH connect()
Increase the minimum timeout a couple seconds here.
Regarding 'LibsshSession(timeout=1)', a very low value must be set here, to allow the timeout set in
to work as expected. This is due to code becoming blocked in libssh which is C not Python, but the Python signal is delayed until we get back to the Python code