-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite pytest-mh documentation #78
Conversation
f79946a
to
b615827
Compare
4b0dc5d
to
762d48a
Compare
If you find any language stuff to correct, feel free to fix it directly and push to my branch as a new commit. We can then just squash it. It will be simpler for everyone. |
PR CI will pass once the other currently opened pull requests will be merged. |
I finished my review and pushed my changes as you suggested. It was a hard work, and I guess it was harder for you since it took you way more time to write it. You’ve done an incredible job. Congratulations! Thank you! |
The old documentation format was not sufficient to cover all the features we have added in the past couple of months. This is a complete rewrite and it should cover everything that is currently supported. It is also more extensible for future features.
Thank you. If I convert it into pdf it is about 40 pages of A4 without the API reference, so it is already a small book :-) Thank you for your hard work. |
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@ikerexxe Please see updated description of MultihostReentrantUtility. |
I started and will be pushing small grammatical changes to your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit with several minor language or grammar related changes. The revised docs look great, thanks for your hard work on them. Ack.
74028fc
to
dfdbc3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the effort to rewrite and improve the documentation. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you, Pavel.
The old documentation format was not sufficient to cover all the features we have added in the past couple of months. This is a complete rewrite and it should cover everything that is currently supported. It is also more extensible for future features.