Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pytest-mh documentation #78

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

pbrezina
Copy link
Contributor

@pbrezina pbrezina commented Sep 11, 2024

The old documentation format was not sufficient to cover all the features we have added in the past couple of months. This is a complete rewrite and it should cover everything that is currently supported. It is also more extensible for future features.

@pbrezina pbrezina force-pushed the docs branch 16 times, most recently from f79946a to b615827 Compare September 11, 2024 16:17
@pbrezina pbrezina force-pushed the docs branch 7 times, most recently from 4b0dc5d to 762d48a Compare September 13, 2024 15:42
@pbrezina
Copy link
Contributor Author

If you find any language stuff to correct, feel free to fix it directly and push to my branch as a new commit. We can then just squash it. It will be simpler for everyone.

@pbrezina
Copy link
Contributor Author

PR CI will pass once the other currently opened pull requests will be merged.

@ikerexxe
Copy link
Contributor

If you find any language stuff to correct, feel free to fix it directly and push to my branch as a new commit. We can then just squash it. It will be simpler for everyone.

I finished my review and pushed my changes as you suggested. It was a hard work, and I guess it was harder for you since it took you way more time to write it. You’ve done an incredible job. Congratulations! Thank you!

The old documentation format was not sufficient to cover all the
features we have added in the past couple of months. This is a
complete rewrite and it should cover everything that is currently
supported. It is also more extensible for future features.
@pbrezina
Copy link
Contributor Author

If you find any language stuff to correct, feel free to fix it directly and push to my branch as a new commit. We can then just squash it. It will be simpler for everyone.

I finished my review and pushed my changes as you suggested. It was a hard work, and I guess it was harder for you since it took you way more time to write it. You’ve done an incredible job. Congratulations! Thank you!

Thank you. If I convert it into pdf it is about 40 pages of A4 without the API reference, so it is already a small book :-) Thank you for your hard work.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@pbrezina
Copy link
Contributor Author

@ikerexxe Please see updated description of MultihostReentrantUtility.

@danlavu
Copy link

danlavu commented Sep 20, 2024

I started and will be pushing small grammatical changes to your branch.

@pbrezina pbrezina marked this pull request as ready for review September 25, 2024 13:18
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit with several minor language or grammar related changes. The revised docs look great, thanks for your hard work on them. Ack.

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the effort to rewrite and improve the documentation. LGTM!

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you, Pavel.

@pbrezina pbrezina merged commit bcab2be into next-actions:master Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants