feat: add example contact on first login #50156
Open
+4,432
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
enhancement
3. to review
st3iny
reviewed
Jan 21, 2025
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
feat/cardav-example-contact
branch
from
b237d7a to
3af4fc4
Compare
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
added
2. developing
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
st3iny
reviewed
Jan 23, 2025
Comment on lines
+39
to
+41
| if ($event->getAddressBookData()['uri'] === CardDavBackend::PERSONAL_ADDRESSBOOK_URI) { | ||
| $this->defaultContactService->createDefaultContact((string)$event->getAddressBookId()); | ||
| } |
There was a problem hiding this comment.
Btw, I fixed the problem of the address book not being available during first login. In case you want to go back to the first login event handler.
Ref #50369
st3iny
reviewed
Jan 23, 2025
| console.log('Event:', event) | ||
|
|
||
| const file = event.target.files[0] | ||
| console.log('Selected file:', file) |
There was a problem hiding this comment.
Suggested change
| console.log('Selected file:', file) |
| this.$refs.exampleContactImportInput.click() | ||
| }, | ||
| processFile(event) { | ||
| console.log('processFile triggered') |
There was a problem hiding this comment.
Suggested change
| console.log('processFile triggered') |
| processFile(event) { | ||
| console.log('processFile triggered') | ||
| this.loading = true | ||
| console.log('Event:', event) |
There was a problem hiding this comment.
Suggested change
| console.log('Event:', event) |
Comment on lines
+51
to
+54
| public function getName(): ?string { | ||
| return 'Example Content'; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| public function getName(): ?string { | |
| return 'Example Content'; | |
| } |
This method does not exist in ISettings.
Comment on lines
+17
to
+25
| <NcButton v-if="enableDefaultContact" | ||
| class="import-button" | ||
| type="primary" | ||
| @click="toggleModal"> | ||
| <template #icon> | ||
| <IconUpload :size="20" /> | ||
| </template> | ||
| {{ $t('dav', 'Import contact') }} | ||
| </NcButton> |
There was a problem hiding this comment.
Perhaps also add a button to clear the custom contact? To reset the example contact to the built-in default value.
| */ | ||
| public function setAppConfig($key, $allow) { | ||
| if ($allow === 'yes' && $key === 'enableDefaultContact' && !$this->defaultContactExists()) { | ||
| $this->setInitialDefaultContact(); |
There was a problem hiding this comment.
This method does not exist.
Call to undefined method OCA\DAV\Controller\ExampleContentController::setInitialDefaultContact() in file '/master/apps/dav/lib/Controller/ExampleContentController.php' line 44
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist