-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/apply rector set to apps #50577
Open
come-nc
wants to merge
4
commits into
master
Choose a base branch
from
enh/apply-rector-set-to-apps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enh/apply rector set to apps #50577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen,
st3iny,
hamza221,
SebastianKrupinski,
tcitworld and
kesselb
as code owners
January 30, 2025 16:20
ChristophWurst
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for caldav/carddav
Those 2 are wrong, should be 'OCP\IUserManager' and 'OCP\IGroupManager'. |
come-nc
added
2. developing
Work in progress
technical debt
and removed
3. to review
Waiting for reviews
labels
Jan 30, 2025
nickvergessen
requested changes
Jan 31, 2025
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/apply-rector-set-to-apps
branch
from
February 3, 2025 14:36
92966bf
to
e37fb47
Compare
// Deprecated since 20.0.0 Use 'get(\OCP\Files\AppData\IAppDataFactory')->get($app) instead
new LegacyGetterToOcpServerGet('getAppDataDir', 'OCP\Files\IAppData'), This is wrong in 25 set. For this PR it can easily be fixed manually I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NextcloudSets::NEXTCLOUD_25
to configurationYou can note that
\OC::$server->get
calls are correctly replaced but not\OC::$server->query
ones, that’s an oversight of the Set and will need to be fixed upstream.Apart from that the changes look sound to me.
Checklist