Cleanup and formatting

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>

modules/nextflow/src/main/groovy/nextflow/cli/CmdCid.groovy

@@ -58,8 +58,6 @@ class CmdCid extends CmdBase {
         commands << new CmdLog()
         commands << new CmdShow()
         commands << new CmdLineage()
-
-
     }
 
     @Parameter(hidden = true)
@@ -115,12 +113,9 @@ class CmdCid extends CmdBase {
                     .build()
             final session = new Session(config)
             printHistory(session.cidStore)
-
         }
 
         private void printHistory(CidStore store) {
-
-
             final historyFile = store.getHistoryFile()
             if (historyFile.exists()) {
                 def table = new TableBuilder(cellSeparator: '\t')
@@ -140,6 +135,7 @@ class CmdCid extends CmdBase {
             println 'Usage: nextflow cid log'
         }
     }
+
     class CmdShow implements SubCmd{
 
         @Override
@@ -176,7 +172,6 @@ class CmdCid extends CmdBase {
         }
     }
 
-
     class CmdLineage implements SubCmd {
 
         @Canonical

modules/nextflow/src/main/groovy/nextflow/data/cid/CidStoreFactory.groovy

@@ -41,9 +41,6 @@ abstract class CidStoreFactory implements ExtensionPoint {
         final factory = all.first()
         log.debug "Using Nextflow CID store factory: ${factory.getClass().getName()}"
         return factory.newInstance(config)
-
-
     }
 
-
 }

modules/nextflow/src/main/groovy/nextflow/data/cid/DefaultCidStore.groovy

@@ -78,5 +78,4 @@ class DefaultCidStore implements CidStore {
 
     static Path getMetadataPath(DataConfig config){ config.store.location.resolve('.meta') }
 
-
 }

modules/nextflow/src/main/groovy/nextflow/data/cid/DefaultCidStoreFactory.groovy

@@ -35,4 +35,5 @@ class DefaultCidStoreFactory extends CidStoreFactory{
         cidStore.open(config)
         return cidStore
     }
+
 }

modules/nextflow/src/main/groovy/nextflow/data/cid/fs/CidFileSystem.groovy

@@ -43,8 +43,8 @@ class CidFileSystem extends FileSystem {
     private Path basePath
 
     /*
-    * Only needed to prevent serialization issues - see https://github.com/nextflow-io/nextflow/issues/5208
-    */
+     * Only needed to prevent serialization issues - see https://github.com/nextflow-io/nextflow/issues/5208
+     */
     protected CidFileSystem(){}
 
     CidFileSystem(CidFileSystemProvider provider, DataConfig config) {

modules/nextflow/src/main/groovy/nextflow/data/cid/fs/CidFileSystemProvider.groovy

@@ -136,7 +136,7 @@ class CidFileSystemProvider extends FileSystemProvider {
 
             @Override
             int read(ByteBuffer dst) throws IOException {
-                channel.read(dst)
+                return channel.read(dst)
             }
 
             @Override
@@ -146,7 +146,7 @@ class CidFileSystemProvider extends FileSystemProvider {
 
             @Override
             long position() throws IOException {
-                channel.position()
+                return channel.position()
             }
 
             @Override
@@ -156,7 +156,7 @@ class CidFileSystemProvider extends FileSystemProvider {
 
             @Override
             long size() throws IOException {
-                channel.size()
+                return channel.size()
             }
 
             @Override
@@ -166,7 +166,7 @@ class CidFileSystemProvider extends FileSystemProvider {
 
             @Override
             boolean isOpen() {
-                channel.isOpen()
+                return channel.isOpen()
             }
 
             @Override

modules/nextflow/src/main/groovy/nextflow/data/cid/fs/CidPath.groovy

@@ -45,11 +45,11 @@ import nextflow.file.FileHelper
 @CompileStatic
 class CidPath implements Path {
 
-    static public String SEPARATOR = '/'
+    static public final String SEPARATOR = '/'
     public static final String METADATA_FILE = '.data.json'
-    public static final String CID_PROT = "${SCHEME}://".toString()
+    public static final String CID_PROT = "${SCHEME}://"
 
-    static private String[] EMPTY = new String[] {}
+    static private final String[] EMPTY = new String[] {}
 
     private CidFileSystem fileSystem
 
@@ -161,7 +161,6 @@ class CidPath implements Path {
             default:
                 return resolve0(fs, more[0], more[1..-1] as String[])
         }
-
     }
 
     static private String norm0(String path) {
@@ -298,7 +297,6 @@ class CidPath implements Path {
         return resolve(that)
     }
 
-
     @Override
     Path relativize(Path other) {
         if( CidPath.class != other.class ) {
@@ -384,5 +382,4 @@ class CidPath implements Path {
         filePath
     }
 
-
 }