Skip to content

Commit

Permalink
Merge branch 'master' into cid-store-m0
Browse files Browse the repository at this point in the history
  • Loading branch information
pditommaso committed Mar 1, 2025
2 parents fdbda27 + c02fe91 commit 84ee951
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/container.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ In the above example replace `/path/to/apptainer.img` with any Apptainer image o
Read the {ref}`config-page` page to learn more about the `nextflow.config` file and how to use it to configure your pipeline execution.

:::{note}
Unlike Docker, Nextflow does not automatically mount host paths in the container when using Apptainer. It expects that the paths are configure and mounted system wide by the Apptainer runtime. If your Apptainer installation allows user defined bind points, read the {ref}`Apptainer configuration <config-apptainer>` section to learn how to enable Nextflow auto mounts.
Unlike Docker, Nextflow does not automatically mount host paths in the container when using Apptainer. It expects that the paths are configured and mounted system wide by the Apptainer runtime. If your Apptainer installation allows user defined bind points, read the {ref}`Apptainer configuration <config-apptainer>` section to learn how to enable Nextflow auto mounts.
:::

:::{warning}
Expand Down
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
org.gradle.caching=true
org.gradle.jvmargs=-Xmx4g
org.gradle.parallel=true
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ class GoogleBatchTaskHandler extends TaskHandler implements FusionAwareTask {
LifecyclePolicy.newBuilder()
.setActionCondition(
LifecyclePolicy.ActionCondition.newBuilder()
.addExitCodes(50001)
.addAllExitCodes(executor.config.autoRetryExitCodes)
)
.setAction(LifecyclePolicy.Action.RETRY_TASK)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ class GoogleBatchTaskHandlerTest extends Specification {
getBootDiskImage() >> BOOT_IMAGE
getCpuPlatform() >> CPU_PLATFORM
getMaxSpotAttempts() >> 5
getAutoRetryExitCodes() >> [50001,50002]
getSpot() >> true
getNetwork() >> 'net-1'
getServiceAccountEmail() >> 'foo@bar.baz'
Expand Down Expand Up @@ -198,7 +199,9 @@ class GoogleBatchTaskHandlerTest extends Specification {
taskSpec.getMaxRunDuration().getSeconds() == TIMEOUT.seconds
taskSpec.getVolumes(0).getMountPath() == '/tmp'
taskSpec.getMaxRetryCount() == 5
taskSpec.getLifecyclePolicies(0).getActionCondition().getExitCodesCount() == 2
taskSpec.getLifecyclePolicies(0).getActionCondition().getExitCodes(0) == 50001
taskSpec.getLifecyclePolicies(0).getActionCondition().getExitCodes(1) == 50002
taskSpec.getLifecyclePolicies(0).getAction().toString() == 'RETRY_TASK'
and:
runnable.getContainer().getCommandsList().join(' ') == '/bin/bash -o pipefail -c bash .command.run'
Expand Down

0 comments on commit 84ee951

Please sign in to comment.