Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using Nextflow secrets for sensitive credentials in configs #5227

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ewels
Copy link
Member

@ewels ewels commented Aug 14, 2024

Put together after pointing someone in the community towards Nextflow Secrets.

Initially was just going to do a couple of tip boxes, but figured that if secrets are the recommended method then maybe the code examples should be using them as well.

Happy to scale this back if the feeling is that it's overkill. On the other hand, also happy to be told if I missed a spot.

@netlify /amazons3.html#aws-access-and-secret-keys

@ewels ewels requested a review from a team as a code owner August 14, 2024 22:26
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 6aeb07c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66c32036894d8200086b0968

@ewels ewels force-pushed the docs-aws-tip-secrets branch from f8430ca to ed3df16 Compare August 14, 2024 22:26
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
@ewels ewels force-pushed the docs-aws-tip-secrets branch from 8f38729 to 6aeb07c Compare August 19, 2024 10:36
@ewels
Copy link
Member Author

ewels commented Sep 24, 2024

@christopher-hakkaart this might be a nice small one for you to review / wrap into other docs changes 😊

@christopher-hakkaart
Copy link
Collaborator

PR to wrap into other docs changes here -> #5325

@pditommaso
Copy link
Member

I believe we should keep config examples simpler, even it can make sense provide to not hard code keys in the config file. Secrets can be a solution, but even better to rely on instance profile or env variables.

@pditommaso pditommaso marked this pull request as draft September 25, 2024 12:47
@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 5a93547 to 27345a6 Compare February 10, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants