feat(AzBatchTaskHandler): Include other output files in final upload statement #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…statement The Azure Batch executor would sometimes fail to upload output files to storage, leaving failed jobs with no indication why. This PR uploads more files to make it easier to debug failed pipelines. Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Screenshot of new output files declaration: |
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
adamrtalbot
commented
Feb 20, 2025
plugins/nf-azure/src/main/nextflow/cloud/azure/batch/AzBatchService.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Batch executor would sometimes fail to upload output files to storage, leaving failed jobs with no indication why. This PR adds the native Azure Batch output file directive for more files which will upload most of the auxiliary files to make it easier to debug failed pipelines.
I'm not 100% sure this will work, but I also can't see any major downside to including these files?