Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container platform to docker command #5847

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add container platform to docker command #5847

wants to merge 2 commits into from

Conversation

pditommaso
Copy link
Member

@pditommaso pditommaso commented Mar 4, 2025 •
edited
Loading

This PR improves the handling of container platform in two ways:

  • Add explicitly the platform to be used to Docker and Podman commands. This is needed to solve the ambiguity on some OS (e.g. macOS) where a container can be executed both as ARM (using silicon) and AMD (via emulation)
  • Default to linux/amd64 when no process.arch is specified for consistency with Wave defaults.

@pditommaso
Add container platform to docker command
8580bd7 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 807c45c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67c701ba21e99f000803a847

@pditommaso
Minor [ci skip]
807c45c 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
software/docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pditommaso @bentsherman