Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes int expectation in golden file testing #463

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fixes int expectation in golden file testing #463

merged 1 commit into from
Dec 19, 2024

Conversation

merschformann
Copy link
Member

Description

Improved the comparison logic when expecting int values to account for float64 values, accommodating JSON's number unmarshaling behavior.

Changes

  • Added a check to convert expected value from float64 to int if necessary.
  • Updated error message to reflect new comparison logic between int and float64 types.

@merschformann merschformann merged commit 141b414 into develop Dec 19, 2024
14 checks passed
@merschformann merschformann deleted the merschformann/fix-int-expected branch December 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkschumacher dirkschumacher dirkschumacher approved these changes

@cowanwalls cowanwalls Awaiting requested review from cowanwalls

@sebastian-quintero sebastian-quintero Awaiting requested review from sebastian-quintero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merschformann @dirkschumacher