Skip to content

Commit

Permalink
Fix typo in OperationCompletionSuccessfulOptions (#19)
Browse files Browse the repository at this point in the history
Closes #16
  • Loading branch information
bergundy authored Sep 13, 2024
1 parent db2665a commit 0fbe710
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions nexus/completion.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ type OperationCompletionSuccessful struct {
Body io.Reader
}

// OperationCompletionSuccesfulOptions are options for [NewOperationCompletionSuccessful].
type OperationCompletionSuccesfulOptions struct {
// OperationCompletionSuccessfulOptions are options for [NewOperationCompletionSuccessful].
type OperationCompletionSuccessfulOptions struct {
// Optional serializer for the result. Defaults to the SDK's default Serializer, which handles JSONables, byte
// slices and nils.
Serializer Serializer
}

// NewOperationCompletionSuccessful constructs an [OperationCompletionSuccessful] from a given result.
func NewOperationCompletionSuccessful(result any, options OperationCompletionSuccesfulOptions) (*OperationCompletionSuccessful, error) {
func NewOperationCompletionSuccessful(result any, options OperationCompletionSuccessfulOptions) (*OperationCompletionSuccessful, error) {
if reader, ok := result.(*Reader); ok {
return &OperationCompletionSuccessful{
Header: addContentHeaderToHTTPHeader(reader.Header, make(http.Header)),
Expand Down
4 changes: 2 additions & 2 deletions nexus/completion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestSuccessfulCompletion(t *testing.T) {
ctx, callbackURL, teardown := setupForCompletion(t, &successfulCompletionHandler{}, nil)
defer teardown()

completion, err := NewOperationCompletionSuccessful(666, OperationCompletionSuccesfulOptions{})
completion, err := NewOperationCompletionSuccessful(666, OperationCompletionSuccessfulOptions{})
completion.Header.Add("foo", "bar")
require.NoError(t, err)

Expand All @@ -60,7 +60,7 @@ func TestSuccessfulCompletion_CustomSerializr(t *testing.T) {
ctx, callbackURL, teardown := setupForCompletion(t, &successfulCompletionHandler{}, serializer)
defer teardown()

completion, err := NewOperationCompletionSuccessful(666, OperationCompletionSuccesfulOptions{
completion, err := NewOperationCompletionSuccessful(666, OperationCompletionSuccessfulOptions{
Serializer: serializer,
})
completion.Header.Add("foo", "bar")
Expand Down
4 changes: 3 additions & 1 deletion nexus/get_result_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ func TestWaitResult_DeadlineExceeded(t *testing.T) {
deadline, _ := ctx.Deadline()
_, err = handle.GetResult(ctx, GetOperationResultOptions{Wait: time.Second})
require.ErrorIs(t, err, context.DeadlineExceeded)
require.WithinDuration(t, deadline, handler.requests[0].deadline, 1*time.Millisecond)
// Allow up to 10 ms delay to account for slow CI.
// This test is inherently flaky, and should be rewritten.
require.WithinDuration(t, deadline, handler.requests[0].deadline, 10*time.Millisecond)
}

func TestWaitResult_RequestTimeout(t *testing.T) {
Expand Down

0 comments on commit 0fbe710

Please sign in to comment.