Skip to content

Commit

Permalink
Use Python 3.8 in validate_python workflow (#963)
Browse files Browse the repository at this point in the history
* Use Python 3.8 in validate_python workflow

* Remove python version specification from validate_examples.py

* Use double quotes validate_examples.py

I'm guessing the single quotes are what black didn't like
  • Loading branch information
ni-jfitzger authored Jul 18, 2023
1 parent 9899539 commit 803487b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/validate_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup python3
uses: actions/setup-python@v2
with:
python-version: '3.7.x'
python-version: '3.8.x'

- name: Install build dependencies
run: python -m pip install -r python_build_requirements.txt
Expand Down
4 changes: 1 addition & 3 deletions source/codegen/validate_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ def _validate_examples(
_system("poetry new .")
_system("poetry add grpcio")
_system("poetry add --dev grpcio-tools mypy mypy-protobuf types-protobuf grpc-stubs")
# black requires python >=3.6.2, so only ask it to be installed for python >=3.6.2, or else
# poetry can give a SolverProblemError and fail the "install" step
_system('poetry add --dev --python ">=3.6.2" black')
_system("poetry add --dev black")
_system("poetry install")

_stage_client_files(artifact_location, staging_dir)
Expand Down

0 comments on commit 803487b

Please sign in to comment.