Fix Accept addrlen initialization #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanou
requested review from
reckenro,
astarche and
maxxboehme
as code owners
jonathanou
changed the title
maxxboehme
requested changes
Nov 6, 2024
astarche
approved these changes
Nov 6, 2024
maxxboehme
approved these changes
Nov 7, 2024
reckenro
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
nxacceptcall.Why should this Pull Request be merged?
Similar to #1107 , the address is also not being populated in the
Acceptcall.What testing has been done?
Manually tested that by setting
addrlentosizeof(addr.storage)the grpc call is now getting the client address.