Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moniker streaming functions return standard reponse message instead of custom data type #1122

Merged
merged 15 commits into from
Nov 26, 2024
Merged

Moniker streaming functions return standard reponse message instead of custom data type #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
78ce3a0
add new meesage to proto for moniker streaming call
doshirohan Nov 16, 2024
36e8360
work-in-progress: codegen changes for service.cpp generation with res…
doshirohan Nov 18, 2024
4392afb
run codegen after resolving merge conflicts
doshirohan Nov 19, 2024
5b013cc
return failure error code from moniker APIs
doshirohan Nov 19, 2024
4324a98
update proto and struct to contain request and response messages
doshirohan Nov 23, 2024
baffd64
standardize to send output in response parameter for moniker APIs
doshirohan Nov 23, 2024
9f3524c
fix black formatter issues
doshirohan Nov 23, 2024
b7da3f8
fix build error
doshirohan Nov 23, 2024
c58b240
cleanup scripts
doshirohan Nov 23, 2024
09f34aa
fix tests
doshirohan Nov 23, 2024
11fff46
script and cpp cleanup
doshirohan Nov 23, 2024
54e6850
add type hints for python helpers
doshirohan Nov 26, 2024
f9c5ce5
fix black formatter issues
doshirohan Nov 26, 2024
314eb0e
return error status from Write* moniker functions
doshirohan Nov 26, 2024
e7b2305
fix type hints
doshirohan Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
170 changes: 170 additions & 0 deletions generated/nidaqmx/nidaqmx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8518,6 +8518,12 @@ message BeginReadAnalogF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadAnalogF64StreamingResponse {
int32 status = 1;
repeated double read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadAnalogScalarF64Request {
nidevice_grpc.Session task = 1;
double timeout = 2;
Expand All @@ -8538,6 +8544,11 @@ message BeginReadAnalogScalarF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadAnalogScalarF64StreamingResponse {
int32 status = 1;
double value = 2;
}

message ReadBinaryI16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8571,6 +8582,12 @@ message BeginReadBinaryI16Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadBinaryI16StreamingResponse {
int32 status = 1;
repeated int32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadBinaryI32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8604,6 +8621,12 @@ message BeginReadBinaryI32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadBinaryI32StreamingResponse {
int32 status = 1;
repeated int32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadBinaryU16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8637,6 +8660,12 @@ message BeginReadBinaryU16Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadBinaryU16StreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadBinaryU32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8670,6 +8699,12 @@ message BeginReadBinaryU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadBinaryU32StreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadCounterF64Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand All @@ -8695,6 +8730,12 @@ message BeginReadCounterF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterF64StreamingResponse {
int32 status = 1;
repeated double read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadCounterF64ExRequest {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8728,6 +8769,12 @@ message BeginReadCounterF64ExResponse {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterF64ExStreamingResponse {
int32 status = 1;
repeated double read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadCounterScalarF64Request {
nidevice_grpc.Session task = 1;
double timeout = 2;
Expand All @@ -8748,6 +8795,11 @@ message BeginReadCounterScalarF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterScalarF64StreamingResponse {
int32 status = 1;
double value = 2;
}

message ReadCounterScalarU32Request {
nidevice_grpc.Session task = 1;
double timeout = 2;
Expand All @@ -8768,6 +8820,11 @@ message BeginReadCounterScalarU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterScalarU32StreamingResponse {
int32 status = 1;
uint32 value = 2;
}

message ReadCounterU32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand All @@ -8793,6 +8850,12 @@ message BeginReadCounterU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterU32StreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadCounterU32ExRequest {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8826,6 +8889,12 @@ message BeginReadCounterU32ExResponse {
ni.data_monikers.Moniker moniker = 2;
}

message ReadCounterU32ExStreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadCtrFreqRequest {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8951,6 +9020,11 @@ message BeginReadDigitalScalarU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadDigitalScalarU32StreamingResponse {
int32 status = 1;
uint32 value = 2;
}

message ReadDigitalU16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -8984,6 +9058,12 @@ message BeginReadDigitalU16Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadDigitalU16StreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadDigitalU32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -9017,6 +9097,12 @@ message BeginReadDigitalU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message ReadDigitalU32StreamingResponse {
int32 status = 1;
repeated uint32 read_array = 2;
int32 samps_per_chan_read = 3;
}

message ReadDigitalU8Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10405,6 +10491,11 @@ message BeginWaitForNextSampleClockResponse {
ni.data_monikers.Moniker moniker = 2;
}

message WaitForNextSampleClockStreamingResponse {
int32 status = 1;
bool is_late = 2;
}

message WaitForValidTimestampRequest {
nidevice_grpc.Session task = 1;
oneof timestamp_event_enum {
Expand Down Expand Up @@ -10461,6 +10552,15 @@ message BeginWriteAnalogF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteAnalogF64StreamingRequest {
repeated double write_array = 1;
}

message WriteAnalogF64StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteAnalogScalarF64Request {
nidevice_grpc.Session task = 1;
bool auto_start = 2;
Expand All @@ -10483,6 +10583,14 @@ message BeginWriteAnalogScalarF64Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteAnalogScalarF64StreamingRequest {
double value = 1;
}

message WriteAnalogScalarF64StreamingResponse {
int32 status = 1;
}

message WriteBinaryI16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10516,6 +10624,15 @@ message BeginWriteBinaryI16Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteBinaryI16StreamingRequest {
repeated int32 write_array = 1;
}

message WriteBinaryI16StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteBinaryI32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10549,6 +10666,15 @@ message BeginWriteBinaryI32Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteBinaryI32StreamingRequest {
repeated int32 write_array = 1;
}

message WriteBinaryI32StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteBinaryU16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10582,6 +10708,15 @@ message BeginWriteBinaryU16Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteBinaryU16StreamingRequest {
repeated uint32 write_array = 1;
}

message WriteBinaryU16StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteBinaryU32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10615,6 +10750,15 @@ message BeginWriteBinaryU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteBinaryU32StreamingRequest {
repeated uint32 write_array = 1;
}

message WriteBinaryU32StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteCtrFreqRequest {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10744,6 +10888,14 @@ message BeginWriteDigitalScalarU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteDigitalScalarU32StreamingRequest {
uint32 value = 1;
}

message WriteDigitalScalarU32StreamingResponse {
int32 status = 1;
}

message WriteDigitalU16Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10777,6 +10929,15 @@ message BeginWriteDigitalU16Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteDigitalU16StreamingRequest {
repeated uint32 write_array = 1;
}

message WriteDigitalU16StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteDigitalU32Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down Expand Up @@ -10810,6 +10971,15 @@ message BeginWriteDigitalU32Response {
ni.data_monikers.Moniker moniker = 2;
}

message WriteDigitalU32StreamingRequest {
repeated uint32 write_array = 1;
}

message WriteDigitalU32StreamingResponse {
int32 status = 1;
int32 samps_per_chan_written = 2;
}

message WriteDigitalU8Request {
nidevice_grpc.Session task = 1;
int32 num_samps_per_chan = 2;
Expand Down
Loading
Loading