Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for DAQ streaming APIs #1138

Merged
merged 30 commits into from
Dec 6, 2024
Merged

Integration tests for DAQ streaming APIs #1138

merged 30 commits into from
Dec 6, 2024

Conversation

doshirohan
Copy link
Contributor

@doshirohan doshirohan commented Dec 4, 2024 •
edited
Loading

What does this Pull Request accomplish?

  • Added tests for various streaming APIs for DAQmx
  • I also had to update mock_library.h.mako to not generate mocked APIs for the ones with > 15 parameters. MOCK_METHOD macro was expanding to something not compilable when param list was more than 15. I don't see any unit/integration tests using these APIs yet, so this should be acceptable.

What testing has been done?

Executed tests locally.

doshirohan and others added 30 commits November 23, 2024 20:30
@doshirohan
add new meesage to proto for moniker streaming call
78ce3a0
@doshirohan
work-in-progress: codegen changes for service.cpp generation with res…
36e8360 
…ponse on moniker out param
@doshirohan
run codegen after resolving merge conflicts
4392afb
@doshirohan
return failure error code from moniker APIs
5b013cc
@doshirohan
update proto and struct to contain request and response messages
4324a98
@doshirohan
standardize to send output in response parameter for moniker APIs
baffd64
@doshirohan
fix black formatter issues
9f3524c
@doshirohan
fix build error
b7da3f8
@doshirohan
cleanup scripts
c58b240
@doshirohan
fix tests
09f34aa
@doshirohan
script and cpp cleanup
11fff46
codegen for read apis with multiple out params
f59d24f
added condition to call reserve and resize functions for some param t…
1a15f05 
…ypes
@doshirohan
add type hints for python helpers
54e6850
@doshirohan
fix black formatter issues
f9c5ce5
@doshirohan
return error status from Write* moniker functions
314eb0e
@doshirohan
fix type hints
e7b2305
Merge branch 'users/rrawat/multiple_param_daqmx' of https://github.co…
4f48972 
…m/ni/grpc-device into users/rrawat/multiple_param_daqmx_write_apis
codegen for write apis with multiple out params
5f8b1c2
Merge branch 'main' of https://github.com/ni/grpc-device into users/r…
ae45956 
…rawat/multiple_param_daqmx
merged latest main
d3ea52a
Merge branch 'users/rrawat/multiple_param_daqmx' of https://github.co…
06e21ce 
…m/ni/grpc-device into users/rrawat/multiple_param_daqmx_write_apis
cleanup
0cfff78
Merge branch 'main' of https://github.com/ni/grpc-device into users/r…
d8a8729 
…rawat/multiple_param_daqmx_write_apis
resolved build errors
fc2b244
@doshirohan
update mock library to exclude methods with more than 15 params; add …
d9e792c 
…more daq tests
@doshirohan
Merge remote-tracking branch 'origin/main' into users/indoshir/daq-in…
4e2e824 
…tegration-tests

* origin/main:
  handle null (#1135)
  cleanup (#1133)
  Add codegen support for Daqmx Write apis which have multiple in params. (#1130)
@doshirohan
fix merge issues
90cf5ec
@doshirohan
cleanup
d722710
@doshirohan
Update CMakeLists.txt
4daef31
@doshirohan doshirohan changed the title Users/indoshir/daq integration tests Integration tests for DAQ streaming APIs Dec 4, 2024
@doshirohan doshirohan marked this pull request as ready for review December 4, 2024 18:00
@doshirohan doshirohan merged commit d2f2862 into main Dec 6, 2024
9 of 10 checks passed
@doshirohan doshirohan deleted the users/indoshir/daq-integration-tests branch December 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghav-NI Raghav-NI Raghav-NI approved these changes

@asumit asumit Awaiting requested review from asumit

@amehra-ni amehra-ni Awaiting requested review from amehra-ni

@reckenro reckenro Awaiting requested review from reckenro reckenro is a code owner

@astarche astarche Awaiting requested review from astarche astarche is a code owner

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doshirohan @Raghav-NI