Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new ID Pin API introduced in mioDAQ #1154

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tjying95
Copy link

@tjying95 tjying95 commented Feb 28, 2025

What does this Pull Request accomplish?

Adding new ID Pin API support introduced in mioDAQ. Depends on this PR: Add new attribute and APIs for mioDAQ ID Pin feature #262
Upgrade Python version to use 3.13 due to some packages no longer supporting Python 3.8.
Pin mypy, mypy-protobuf and types-protobuf versions since their latest versions dropped support for Python 3.8.

Why should this Pull Request be merged?

As part of the changes to support the API in nidaqmx-python.

What testing has been done?

Local build successfully.
Export can be consumed by nidaqmx-python.

Signed-off-by: Jun Ying Tan <9677893+tjying95@users.noreply.github.com>
Signed-off-by: Jun Ying Tan <9677893+tjying95@users.noreply.github.com>
@tjying95 tjying95 marked this pull request as ready for review February 28, 2025 08:29
@tjying95
Copy link
Author

tjying95 commented Mar 3, 2025

Seems like PR / Run CI / build_nilrt / NILRT Cross Compile with GCC 6.3.0 (pull_request) is failing with "‘uint8_t’ has not been declared" now:

...
FAILED: grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o 
/usr/bin/c++ -D_BUILDING_GRPC_SIDEBAND -I/home/runner/work/grpc-device/grpc-device/build/grpc-sideband -I/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src -std=c++11 -O3 -DNDEBUG -MD -MT grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -MF grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o.d -o grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -c /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc
In file included from /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc:5:
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:48:61: error: ‘uint8_t’ has not been declared
   48 | int32_t _SIDEBAND_FUNC WriteSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bytecount);
      |                                                             ^~~~~~~
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:49:60: error: ‘uint8_t’ has not been declared
   49 | int32_t _SIDEBAND_FUNC ReadSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bufferSize, int64_t* numBytesRead);
      |                                                            ^~~~~~~
...

Did some submodules got upgraded as well?

@tjying95
Copy link
Author

tjying95 commented Mar 5, 2025

Seems like PR / Run CI / build_nilrt / NILRT Cross Compile with GCC 6.3.0 (pull_request) is failing with "‘uint8_t’ has not been declared" now:

...
FAILED: grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o 
/usr/bin/c++ -D_BUILDING_GRPC_SIDEBAND -I/home/runner/work/grpc-device/grpc-device/build/grpc-sideband -I/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src -std=c++11 -O3 -DNDEBUG -MD -MT grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -MF grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o.d -o grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -c /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc
In file included from /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc:5:
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:48:61: error: ‘uint8_t’ has not been declared
   48 | int32_t _SIDEBAND_FUNC WriteSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bytecount);
      |                                                             ^~~~~~~
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:49:60: error: ‘uint8_t’ has not been declared
   49 | int32_t _SIDEBAND_FUNC ReadSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bufferSize, int64_t* numBytesRead);
      |                                                            ^~~~~~~
...

Did some submodules got upgraded as well?

I tried building grpc-device by itself, seems working, seems working on windows and I believe non-cross-compiling linux.
I tried following the steps in build_nilrt.yml in an Ubuntu VM, can't get that to work yet.

Any idea? @bkeryan @zhindes

@zhindes
Copy link
Contributor

zhindes commented Mar 5, 2025

Seems like PR / Run CI / build_nilrt / NILRT Cross Compile with GCC 6.3.0 (pull_request) is failing with "‘uint8_t’ has not been declared" now:

...
FAILED: grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o 
/usr/bin/c++ -D_BUILDING_GRPC_SIDEBAND -I/home/runner/work/grpc-device/grpc-device/build/grpc-sideband -I/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src -std=c++11 -O3 -DNDEBUG -MD -MT grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -MF grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o.d -o grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -c /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc
In file included from /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc:5:
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:48:61: error: ‘uint8_t’ has not been declared
   48 | int32_t _SIDEBAND_FUNC WriteSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bytecount);
      |                                                             ^~~~~~~
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:49:60: error: ‘uint8_t’ has not been declared
   49 | int32_t _SIDEBAND_FUNC ReadSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bufferSize, int64_t* numBytesRead);
      |                                                            ^~~~~~~
...

Did some submodules got upgraded as well?

I tried building grpc-device by itself, seems working, seems working on windows and I believe non-cross-compiling linux. I tried following the steps in build_nilrt.yml in an Ubuntu VM, can't get that to work yet.

Any idea? @bkeryan @zhindes

I got nothing... maybe @astarche or @reckenro would know? I'm not a maintainer or active here :(

@maxxboehme
Copy link
Collaborator

Seems like PR / Run CI / build_nilrt / NILRT Cross Compile with GCC 6.3.0 (pull_request) is failing with "‘uint8_t’ has not been declared" now:

...
FAILED: grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o 
/usr/bin/c++ -D_BUILDING_GRPC_SIDEBAND -I/home/runner/work/grpc-device/grpc-device/build/grpc-sideband -I/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src -std=c++11 -O3 -DNDEBUG -MD -MT grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -MF grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o.d -o grpc-sideband/CMakeFiles/ni_grpc_sideband.dir/src/sideband_shared_memory.cc.o -c /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc
In file included from /home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/src/sideband_shared_memory.cc:5:
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:48:61: error: ‘uint8_t’ has not been declared
   48 | int32_t _SIDEBAND_FUNC WriteSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bytecount);
      |                                                             ^~~~~~~
/home/runner/work/grpc-device/grpc-device/third_party/grpc-sideband/./src/sideband_data.h:49:60: error: ‘uint8_t’ has not been declared
   49 | int32_t _SIDEBAND_FUNC ReadSidebandData(int64_t dataToken, uint8_t* bytes, int64_t bufferSize, int64_t* numBytesRead);
      |                                                            ^~~~~~~
...

Did some submodules got upgraded as well?

I tried building grpc-device by itself, seems working, seems working on windows and I believe non-cross-compiling linux. I tried following the steps in build_nilrt.yml in an Ubuntu VM, can't get that to work yet.

Any idea? @bkeryan @zhindes

The grpc-sideband dependency hasn't been updated in about 4 months not sure why it would start failing now especially with an error about that datatype.

@bkeryan
Copy link
Contributor

bkeryan commented Mar 5, 2025

Seems like PR / Run CI / build_nilrt / NILRT Cross Compile with GCC 6.3.0 (pull_request) is failing with "‘uint8_t’ has not been declared" now:

It's being tracked here: https://dev.azure.com/ni/DevCentral/_workitems/edit/3042775
@tjying95 @maxxboehme @astarche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants