Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export products as dataframe #102
base: master
Are you sure you want to change the base?
feat: Export products as dataframe #102
Changes from 4 commits
42725e5
2886cb2
47447c6
1c5d889
84891eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dict
has anexclude_none
option that would apply to this use since we're just going to drop those columns anyway. If we don't add them to the dict version of the object then that could save some fraction of time to checking which columns are empty. If that is reliable be might be able to drop thedropna
call altogether, which is probably a bigger win. Or maybe pandas is smart and can do this efficiently regardless. This SO post shows how to do a quick performance test to see if it makes any difference. It would probably be more significant on models that have more fields like results.Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not add this unit folder and stick with the existing file layout. That would mean putting your tests in a product folder alongside
core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to verifying the column names match the expected, would you also check the column data types? In particular that the dates are dates and arrays are arrays