Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup! #53

Merged
merged 23 commits into from
Jan 9, 2025
Merged

Cleanup! #53

merged 23 commits into from
Jan 9, 2025

Conversation

ninehusky
Copy link
Owner

Closes #51.

From here on out -- the expectation for PRs will be much higher!

@ninehusky ninehusky marked this pull request as draft December 28, 2024 02:55
@ninehusky ninehusky marked this pull request as ready for review January 8, 2025 00:25
ninehusky
ninehusky commented Jan 9, 2025
View reviewed changes
Copy link
Owner Author

@ninehusky ninehusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments, and then is probably good to merge for now. I don't think we'll reach the goal of "getting runnable prototype with this PR", but it should be decent enough to give to other people.

.gitignore Outdated Show resolved Hide resolved
src/chomper.rs Outdated Show resolved Hide resolved
src/chomper.rs Show resolved Hide resolved
src/chomper.rs Outdated Show resolved Hide resolved
src/chomper.rs Outdated Show resolved Hide resolved
src/ite.rs Show resolved Hide resolved
src/language.rs
}
}

// TODO: fix mii so that cond(lhs) holds, and that we don't just do the non-conditional
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

src/language.rs Outdated Show resolved Hide resolved
tests/halide/mod.rs Outdated Show resolved Hide resolved
tests/halide/mod.rs Outdated Show resolved Hide resolved
@ninehusky
Copy link
Owner Author

All comments resolved. Woohoo!

@ninehusky ninehusky merged commit 6238b35 into main Jan 9, 2025
1 check failed
@ninehusky ninehusky deleted the ninehusky-cleanup branch January 9, 2025 21:29
@ninehusky ninehusky mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup!
1 participant
@ninehusky