Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let user pass extra attributes #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

let user pass extra attributes #16

wants to merge 3 commits into from

Conversation

hosmelq
Copy link

@hosmelq hosmelq commented Feb 13, 2018

No description provided.

@nitish24p
Copy link
Owner

can you put forth a use case?

@hosmelq
Copy link
Author

hosmelq commented Feb 13, 2018

@nitish24p if you need to pass any other attribute to <img /> you can not.

For example, I need to pass custom alt and aria attributes.

@manjula-dube
Copy link
Collaborator

So you want to have a support to pass alt and aria attributes as props Right?

@kurtextrem
Copy link
Contributor

This is a nice PR, as it allows every prop a user wants. For example height, width and the new decoding as well. (Decoding ref is here: https://html.spec.whatwg.org/multipage/images.html#image-decoding-hint - afaik only Chrome implemented it yet)

@hosmelq
Copy link
Author

hosmelq commented Feb 14, 2018

Yes @manjula91 and any other attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants