Merge pull request #131 from njtierney/zip-tempdir

Fix missing data when `preserve_metadata = "zip"`
njtierney · Jan 7, 2025 · 044536b · 044536b
2 parents fe0ba8a + f6c59a8
commit 044536b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/R/tar-terra-rast.R b/R/tar-terra-rast.R
@@ -137,7 +137,10 @@ tar_terra_rast <- function(name,
 tar_rast_read <- function(preserve_metadata) {
   switch(preserve_metadata,
     zip = function(path) {
-      tmp <- withr::local_tempdir()
+      tmp <- tempdir()
+      # NOTE: cannot use withr::local_tempdir() because the unzipped files need
+      # to persist so that the resulting `SpatRaster` object doesn't have a
+      # broken file pointer
       zip::unzip(zipfile = path, exdir = tmp)
       terra::rast(file.path(tmp, basename(path)))
     },

diff --git a/tests/testthat/test-tar-terra-rast.R b/tests/testthat/test-tar-terra-rast.R
@@ -143,11 +143,13 @@ tar_test("metadata is maintained", {
       r
     }
     list(
-      tar_terra_rast(r, make_rast())
+      tar_terra_rast(r, make_rast()),
+      tar_terra_rast(r2, make_rast(), preserve_metadata = "drop")
     )
   })
   tar_make()
   x <- tar_read(r)
   expect_equal(terra::units(x), rep("m", 3))
   expect_equal(terra::time(x), as.Date("2024-10-01") + c(0, 1, 2))
+  expect_equal(head(terra::values(x)), head(terra::values(tar_read(r2))))
 })