Fix issue with LightboxSpatieMediaLibraryImageEntry when no conversio…

…n is set
njxqlus · Nov 7, 2024 · aa3e869 · aa3e869
1 parent f6dfceb
commit aa3e869
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php b/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php
@@ -41,7 +41,7 @@ protected function makeLightboxEntryFromMedia(Media $media): LightboxImageEntry
 
         if ($this->getVisibility() === 'private') {
             try {
-                if ($this->getConversion() && $media->hasGeneratedConversion($this->getConversion())) {
+                if (filled($this->getConversion()) && $media->hasGeneratedConversion($this->getConversion())) {
                     $entry->state($media->getTemporaryUrl(now()->addMinutes(5), $this->getConversion()));
                 } else {
                     $entry->state($media->getTemporaryUrl(now()->addMinutes(5)));
@@ -51,7 +51,7 @@ protected function makeLightboxEntryFromMedia(Media $media): LightboxImageEntry
                 // This driver does not support creating temporary URLs.
             }
         } else {
-            if ($this->getConversion() && $media->hasGeneratedConversion($this->getConversion())) {
+            if (filled($this->getConversion()) && $media->hasGeneratedConversion($this->getConversion())) {
                 $entry->state($media->getFullUrl($this->getConversion()));
             } else {
                 $entry->state($media->getFullUrl());