Skip to content

Commit

Permalink
Added a note about why we're not adding the NDEBUG compiler flag unde…
Browse files Browse the repository at this point in the history
…r MMF 2 (which we added for MMF 3.0.3)
  • Loading branch information
noah-nuebling committed Sep 18, 2024
1 parent 9805621 commit ece7611
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions xcconfig/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@
- The generate_appcasts.py script will go through all releases, and look at their related commits. Within those, it'll look into [ProjectRoot]/xcconfig/Base.xcconfig and search for the value to MACOSX_DEPLOYMENT_TARGET in there.
- So if we refactor Base.xcconfig, we need to adjust the generate_appcasts.py script, too

- (Sep 2024) Considered adding NDEBUG preprocessor macro like we did for MMF 3.0.3 to prevent assert() failures from crashing in release builds.
However, MMF 2 never seems to crash anyways, and I'm worried that, if we don't crash when there's an assert failure
while processing the launchd.plist or config.plist files, then perhaps those could get corrupted leading to worse issues than a crash...
I'd just rather not touch this stuff and so decided against adding the NDEBUG flag under MMF 2.

0 comments on commit ece7611

Please sign in to comment.