feat: Implement UpdatableAdapter on adapter #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece @Shivansh-yadav13 please review |
|
Sorry for the spam on the other PRs -- I had to make sure CI passed and did't want to deal with fixing the commits :) |
jkalberer
commented
Mar 26, 2024
Comment on lines
-12
to
-13
| "lint": "eslint src/**/*.{ts,tsx,js,jsx}", | ||
| "fix": "eslint src/**/*.{ts,tsx,js,jsx} --fix", |
There was a problem hiding this comment.
This was failing for me on my mac for some reason...?
This updates the adapter so that we can use updatePolicy from the enforcer. I also set up local testing to use sqlite so we can run the tests without a mysql instance.
jkalberer
force-pushed
the
implement_updatableadapter
branch
from
4b1de65 to
cc727c9
Compare
This was referenced Mar 27, 2024
|
You should fix your commits in existing PR, not creating new PRs |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@hsluoyz - yep, apologies. I didn't know I could just amend and force push. Will do so in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the adapter so that we can use updatePolicy from the enforcer.
I also set up local testing to use sqlite so we can run the tests without a mysql instance.