feat(brillig): Hoist shared constants across functions to the global space

[vezenovm]

Description

Problem*

Resolves #7109

Summary*

Before compiling Brillig globals we run an analysis to see which constants are shared across multiple functions. Those values are allocated along with the user-defined globals and then special cased when compiling regular functions. Any repeat constants across functions should be a part of the global read-only memory space and will live throughout the program.

1. When building our BrilligGlobals context structure we now maintain a new map:

/// Maps entry point to constants 
hoisted_global_constants: HashMap<FunctionId, ConstantCounterMap>,
/// Mapping of a constant value and the number of functions in which it occurs
pub(crate) type ConstantCounterMap = HashMap<(FieldElement, NumericType), usize>;

2. NB: I re-computed ConstantAllocation to determine which constant appears in both functions. This was technically recomputed as we calculate a ConstantAllocation when creating a FunctionContext. For now, I decided to recompute it as it has a minor affect on compilation, but just noting this is a place of optimization in the future.
3. When compiling globals, we fetch the constants which appear in more than one function.
4. After compiling the user specified globals, we compile the hoisted global constants.
5. Maintain a separate map for entry points to their hoisted globals:

/// Final map that associates an entry point with any local function constants
/// that are shared and were hoisted to the global space.
/// This map is kept separate from `entry_point_globals_map` to clearly distinguish
/// the two types of globals.
entry_point_hoisted_globals_map: HashMap<FunctionId, HoistedConstantsToBrilligGlobals>,
pub(crate) type HoistedConstantsToBrilligGlobals =
    HashMap<(FieldElement, NumericType), BrilligVariable>;

6. When compiling regular Brillig blocks we gate liveness analysis on checking whether a variable is actually a hoisted constant, not only on dfg.is_global.
7. When converting a variable we escape early if it is a hoisted constant.

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Changes to Brillig bytecode sizes

Generated at commit: bd32a975763f744cd5878867421a026fb4dab29c, compared to commit: a9e985064303b0843cbf68fb5a9d41f9ade1e30d

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
trait_impl_base_type_inliner_min	-10 ✅	-4.00%
brillig_calls_array_inliner_min	-9 ✅	-4.09%
regression_unsafe_no_predicates_inliner_min	-4 ✅	-4.35%
uhashmap_inliner_zero	-328 ✅	-4.36%
brillig_calls_conditionals_inliner_min	-6 ✅	-4.48%
brillig_calls_conditionals_inliner_zero	-6 ✅	-4.48%
references_inliner_min	-20 ✅	-4.75%
slices_inliner_min	-122 ✅	-4.81%
simple_print_inliner_min	-12 ✅	-5.17%
regression_3051_inliner_min	-10 ✅	-5.18%
higher_order_functions_inliner_min	-75 ✅	-5.54%
brillig_calls_inliner_min	-11 ✅	-5.70%
reference_counts_inliner_zero	-40 ✅	-6.01%
hashmap_inliner_min	-618 ✅	-6.29%
uhashmap_inliner_min	-532 ✅	-6.36%
debug_logs_inliner_min	-763 ✅	-7.82%
reference_counts_inliner_min	-69 ✅	-8.22%
prelude_inliner_min	-19 ✅	-8.37%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
hashmap_inliner_max	19,752 (-14)	-0.07%
u128_inliner_max	2,693 (-3)	-0.11%
keccak256_inliner_zero	1,972 (-3)	-0.15%
nested_array_dynamic_inliner_min	1,952 (-3)	-0.15%
nested_array_dynamic_inliner_zero	1,952 (-3)	-0.15%
keccak256_inliner_min	1,670 (-3)	-0.18%
sha2_byte_inliner_zero	2,218 (-4)	-0.18%
regression_inliner_zero	967 (-2)	-0.21%
ram_blowup_regression_inliner_zero	953 (-2)	-0.21%
modulus_inliner_min	1,761 (-5)	-0.28%
array_dynamic_blackbox_input_inliner_zero	1,029 (-3)	-0.29%
nested_array_in_slice_inliner_min	1,015 (-3)	-0.29%
nested_array_in_slice_inliner_zero	1,015 (-3)	-0.29%
poseidon_bn254_hash_inliner_zero	4,687 (-15)	-0.32%
poseidon_bn254_hash_width_3_inliner_zero	4,687 (-15)	-0.32%
ecdsa_secp256k1_inliner_zero	915 (-3)	-0.33%
brillig_cow_regression_inliner_zero	2,116 (-7)	-0.33%
array_dynamic_nested_blackbox_input_inliner_zero	892 (-3)	-0.34%
wildcard_type_inliner_min	291 (-1)	-0.34%
poseidonsponge_x5_254_inliner_zero	3,009 (-11)	-0.36%
array_dedup_regression_inliner_min	267 (-1)	-0.37%
sha256_brillig_performance_regression_inliner_zero	1,700 (-7)	-0.41%
regression_5252_inliner_zero	3,381 (-14)	-0.41%
brillig_cow_inliner_zero	238 (-1)	-0.42%
conditional_1_inliner_zero	1,121 (-5)	-0.44%
regression_4449_inliner_zero	770 (-4)	-0.52%
to_le_bytes_inliner_min	170 (-1)	-0.58%
6_inliner_zero	838 (-5)	-0.59%
array_dynamic_inliner_min	326 (-2)	-0.61%
uhashmap_inliner_max	12,650 (-78)	-0.61%
slice_coercion_inliner_min	486 (-3)	-0.61%
sha256_var_witness_const_regression_inliner_zero	806 (-5)	-0.62%
assert_inliner_min	160 (-1)	-0.62%
generics_inliner_zero	160 (-1)	-0.62%
conditional_regression_661_inliner_zero	160 (-1)	-0.62%
poseidonsponge_x5_254_inliner_min	3,148 (-20)	-0.63%
7_inliner_min	153 (-1)	-0.65%
blake3_inliner_min	153 (-1)	-0.65%
brillig_blake2s_inliner_min	150 (-1)	-0.66%
array_sort_inliner_max	290 (-2)	-0.68%
array_sort_inliner_zero	290 (-2)	-0.68%
aes128_encrypt_inliner_min	434 (-3)	-0.69%
bench_2_to_17_inliner_zero	288 (-2)	-0.69%
bigint_inliner_zero	1,864 (-14)	-0.75%
poseidon_bn254_hash_width_3_inliner_min	5,010 (-38)	-0.75%
poseidon_bn254_hash_inliner_min	5,010 (-38)	-0.75%
conditional_regression_short_circuit_inliner_zero	918 (-7)	-0.76%
sha256_regression_inliner_zero	4,843 (-37)	-0.76%
aes128_encrypt_inliner_zero	388 (-3)	-0.77%
side_effects_constrain_array_inliner_min	126 (-1)	-0.79%
side_effects_constrain_array_inliner_zero	126 (-1)	-0.79%
array_to_slice_inliner_zero	744 (-6)	-0.80%
slice_regex_inliner_zero	1,690 (-14)	-0.82%
embedded_curve_ops_inliner_zero	358 (-3)	-0.83%
binary_operator_overloading_inliner_min	355 (-3)	-0.84%
to_bytes_integration_inliner_min	229 (-2)	-0.87%
reference_only_used_as_alias_inliner_min	335 (-3)	-0.89%
sha256_var_size_regression_inliner_zero	1,092 (-10)	-0.91%
sha256_brillig_performance_regression_inliner_min	1,842 (-17)	-0.91%
brillig_cow_inliner_min	318 (-3)	-0.93%
slice_loop_inliner_zero	317 (-3)	-0.94%
array_eq_inliner_min	105 (-1)	-0.94%
bigint_inliner_min	1,977 (-19)	-0.95%
fold_distinct_return_inliner_min	101 (-1)	-0.98%
poseidon2_inliner_zero	295 (-3)	-1.01%
slices_inliner_zero	2,070 (-22)	-1.05%
fold_complex_outputs_inliner_zero	551 (-6)	-1.08%
struct_inputs_inliner_zero	254 (-3)	-1.17%
conditional_regression_661_inliner_min	165 (-2)	-1.20%
regression_5252_inliner_min	3,545 (-43)	-1.20%
derive_inliner_zero	329 (-4)	-1.20%
fold_2_to_17_inliner_zero	397 (-5)	-1.24%
brillig_cow_regression_inliner_min	2,349 (-30)	-1.26%
strings_inliner_zero	925 (-12)	-1.28%
tuple_inputs_inliner_min	306 (-4)	-1.29%
tuple_inputs_inliner_zero	306 (-4)	-1.29%
ecdsa_secp256k1_inliner_min	1,207 (-16)	-1.31%
binary_operator_overloading_inliner_zero	225 (-3)	-1.32%
simple_2d_array_inliner_min	144 (-2)	-1.37%
loop_invariant_regression_inliner_min	143 (-2)	-1.38%
sha2_byte_inliner_min	2,964 (-42)	-1.40%
array_sort_inliner_min	350 (-5)	-1.41%
brillig_arrays_inliner_min	140 (-2)	-1.41%
sha256_var_padding_regression_inliner_zero	2,926 (-42)	-1.42%
pedersen_check_inliner_min	549 (-8)	-1.44%
brillig_pedersen_inliner_min	549 (-8)	-1.44%
conditional_1_inliner_min	1,406 (-21)	-1.47%
ram_blowup_regression_inliner_min	1,131 (-17)	-1.48%
sha256_var_size_regression_inliner_min	1,239 (-19)	-1.51%
6_inliner_min	1,004 (-16)	-1.57%
brillig_calls_array_inliner_zero	184 (-3)	-1.60%
sha256_var_witness_const_regression_inliner_min	978 (-16)	-1.61%
array_dynamic_nested_blackbox_input_inliner_min	1,190 (-20)	-1.65%
regression_inliner_min	1,103 (-19)	-1.69%
regression_6734_inliner_min	58 (-1)	-1.69%
array_dynamic_blackbox_input_inliner_min	1,263 (-22)	-1.71%
struct_inputs_inliner_min	287 (-5)	-1.71%
to_be_bytes_inliner_min	226 (-4)	-1.74%
regression_4449_inliner_min	1,057 (-19)	-1.77%
debug_logs_inliner_zero	5,327 (-96)	-1.77%
conditional_regression_short_circuit_inliner_min	1,101 (-20)	-1.78%
slice_loop_inliner_min	327 (-6)	-1.80%
regression_4124_inliner_min	54 (-1)	-1.82%
loop_inliner_min	108 (-2)	-1.82%
conditional_2_inliner_min	161 (-3)	-1.83%
sha256_regression_inliner_min	5,220 (-98)	-1.84%
higher_order_functions_inliner_zero	721 (-14)	-1.90%
generics_inliner_min	239 (-5)	-2.05%
no_predicates_numeric_generic_poseidon_inliner_zero	562 (-12)	-2.09%
fold_numeric_generic_poseidon_inliner_zero	562 (-12)	-2.09%
7_function_inliner_zero	509 (-11)	-2.12%
brillig_rc_regression_6123_inliner_min	231 (-5)	-2.12%
hint_black_box_inliner_zero	364 (-8)	-2.15%
brillig_conditional_inliner_min	45 (-1)	-2.17%
conditional_regression_547_inliner_min	44 (-1)	-2.22%
hash_to_field_inliner_min	216 (-5)	-2.26%
sha256_inliner_zero	1,220 (-29)	-2.32%
regression_6674_1_inliner_min	292 (-7)	-2.34%
hint_black_box_inliner_min	374 (-9)	-2.35%
sha256_inliner_min	1,369 (-33)	-2.35%
global_var_regression_simple_inliner_min	163 (-4)	-2.40%
slice_regex_inliner_min	2,075 (-52)	-2.44%
7_function_inliner_min	634 (-16)	-2.46%
brillig_nested_arrays_inliner_zero	235 (-6)	-2.49%
brillig_nested_arrays_inliner_min	268 (-7)	-2.55%
u128_inliner_zero	1,928 (-52)	-2.63%
global_consts_inliner_min	258 (-7)	-2.64%
simple_shield_inliner_min	840 (-23)	-2.67%
nested_arrays_from_brillig_inliner_min	182 (-5)	-2.67%
regression_11294_inliner_min	471 (-13)	-2.69%
sha256_var_padding_regression_inliner_min	3,156 (-88)	-2.71%
regression_bignum_inliner_min	351 (-10)	-2.77%
references_inliner_zero	240 (-7)	-2.83%
regression_6674_3_inliner_min	842 (-25)	-2.88%
fold_numeric_generic_poseidon_inliner_min	622 (-19)	-2.96%
no_predicates_numeric_generic_poseidon_inliner_min	622 (-19)	-2.96%
trait_impl_base_type_inliner_zero	64 (-2)	-3.03%
fold_complex_outputs_inliner_min	685 (-22)	-3.11%
regression_5045_inliner_min	217 (-7)	-3.13%
regression_6674_2_inliner_min	296 (-10)	-3.27%
inline_decompose_hint_brillig_call_inliner_min	235 (-8)	-3.29%
fmtstr_with_global_inliner_min	117 (-4)	-3.31%
fold_2_to_17_inliner_min	388 (-14)	-3.48%
u128_inliner_min	2,205 (-80)	-3.50%
bench_2_to_17_inliner_min	357 (-13)	-3.51%
slice_dynamic_index_inliner_min	2,688 (-98)	-3.52%
brillig_acir_as_brillig_inliner_min	109 (-4)	-3.54%
derive_inliner_min	572 (-21)	-3.54%
array_to_slice_inliner_min	981 (-37)	-3.63%
embedded_curve_ops_inliner_min	496 (-19)	-3.69%
poseidon2_inliner_min	364 (-14)	-3.70%
hashmap_inliner_zero	7,579 (-309)	-3.92%
strings_inliner_min	1,093 (-45)	-3.95%
trait_impl_base_type_inliner_min	240 (-10)	-4.00%
brillig_calls_array_inliner_min	211 (-9)	-4.09%
regression_unsafe_no_predicates_inliner_min	88 (-4)	-4.35%
uhashmap_inliner_zero	7,187 (-328)	-4.36%
brillig_calls_conditionals_inliner_min	128 (-6)	-4.48%
brillig_calls_conditionals_inliner_zero	128 (-6)	-4.48%
references_inliner_min	401 (-20)	-4.75%
slices_inliner_min	2,415 (-122)	-4.81%
simple_print_inliner_min	220 (-12)	-5.17%
regression_3051_inliner_min	183 (-10)	-5.18%
higher_order_functions_inliner_min	1,280 (-75)	-5.54%
brillig_calls_inliner_min	182 (-11)	-5.70%
reference_counts_inliner_zero	626 (-40)	-6.01%
hashmap_inliner_min	9,212 (-618)	-6.29%
uhashmap_inliner_min	7,828 (-532)	-6.36%
debug_logs_inliner_min	8,988 (-763)	-7.82%
reference_counts_inliner_min	770 (-69)	-8.22%
prelude_inliner_min	208 (-19)	-8.37%

[github-actions]

Changes to number of Brillig opcodes executed

Generated at commit: bd32a975763f744cd5878867421a026fb4dab29c, compared to commit: a9e985064303b0843cbf68fb5a9d41f9ade1e30d

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
regression_5045_inliner_min	+3 ❌	+13.64%
regression_unsafe_no_predicates_inliner_min	+2 ❌	+8.33%
brillig_nested_arrays_inliner_min	-20 ✅	-4.09%
references_inliner_min	-27 ✅	-4.21%
brillig_calls_array_inliner_min	-12 ✅	-4.46%
higher_order_functions_inliner_min	-103 ✅	-4.50%
strings_inliner_min	-138 ✅	-4.77%
regression_3051_inliner_min	-10 ✅	-4.98%
simple_print_inliner_min	-12 ✅	-5.00%
inline_decompose_hint_brillig_call_inliner_min	-14 ✅	-5.11%
embedded_curve_ops_inliner_min	-37 ✅	-5.56%
brillig_calls_inliner_min	-11 ✅	-5.82%
brillig_calls_conditionals_inliner_min	-14 ✅	-7.07%
brillig_calls_conditionals_inliner_zero	-14 ✅	-7.07%
reference_counts_inliner_min	-73 ✅	-7.53%
debug_logs_inliner_min	-814 ✅	-7.89%
reference_counts_inliner_zero	-58 ✅	-8.01%
prelude_inliner_min	-19 ✅	-8.09%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
regression_5045_inliner_min	25 (+3)	+13.64%
regression_unsafe_no_predicates_inliner_min	26 (+2)	+8.33%
global_var_regression_entry_points_inliner_min	135,428 (-4)	-0.00%
modulus_inliner_min	18,016 (-5)	-0.03%
keccak256_inliner_min	32,096 (-9)	-0.03%
keccak256_inliner_zero	31,715 (-9)	-0.03%
to_bytes_integration_inliner_min	4,249 (-2)	-0.05%
poseidonsponge_x5_254_inliner_zero	202,145 (-121)	-0.06%
regression_5252_inliner_zero	1,007,710 (-647)	-0.06%
array_eq_inliner_min	1,202 (-1)	-0.08%
7_inliner_min	1,061 (-1)	-0.09%
blake3_inliner_min	1,061 (-1)	-0.09%
brillig_blake2s_inliner_min	1,058 (-1)	-0.09%
aes128_encrypt_inliner_zero	3,075 (-3)	-0.10%
loop_invariant_regression_inliner_min	1,665 (-2)	-0.12%
poseidon_bn254_hash_inliner_zero	182,256 (-229)	-0.13%
poseidon_bn254_hash_width_3_inliner_zero	182,256 (-229)	-0.13%
regression_inliner_zero	2,716 (-4)	-0.15%
aes128_encrypt_inliner_min	3,479 (-6)	-0.17%
poseidonsponge_x5_254_inliner_min	206,220 (-369)	-0.18%
hashmap_inliner_max	48,293 (-88)	-0.18%
to_be_bytes_inliner_min	2,126 (-4)	-0.19%
regression_5252_inliner_min	1,030,589 (-2,010)	-0.19%
wildcard_type_inliner_min	459 (-1)	-0.22%
poseidon_bn254_hash_inliner_min	185,373 (-600)	-0.32%
poseidon_bn254_hash_width_3_inliner_min	185,373 (-600)	-0.32%
brillig_cow_inliner_zero	800 (-3)	-0.37%
array_dynamic_inliner_min	505 (-2)	-0.39%
array_dedup_regression_inliner_min	1,230 (-5)	-0.40%
global_consts_inliner_min	1,702 (-7)	-0.41%
array_dynamic_nested_blackbox_input_inliner_zero	4,490 (-22)	-0.49%
hash_to_field_inliner_min	968 (-5)	-0.51%
bench_2_to_17_inliner_zero	609,451 (-3,268)	-0.53%
sha256_var_witness_const_regression_inliner_zero	6,962 (-39)	-0.56%
conditional_1_inliner_zero	5,499 (-31)	-0.56%
brillig_cow_inliner_min	1,407 (-8)	-0.57%
reference_only_used_as_alias_inliner_min	495 (-3)	-0.60%
slice_coercion_inliner_min	469 (-3)	-0.64%
conditional_regression_661_inliner_zero	151 (-1)	-0.66%
regression_inliner_min	3,042 (-21)	-0.69%
side_effects_constrain_array_inliner_min	138 (-1)	-0.72%
side_effects_constrain_array_inliner_zero	138 (-1)	-0.72%
array_sort_inliner_max	515 (-4)	-0.77%
array_sort_inliner_zero	515 (-4)	-0.77%
assert_inliner_min	127 (-1)	-0.78%
poseidon2_inliner_zero	723 (-6)	-0.82%
6_inliner_zero	4,424 (-37)	-0.83%
fold_distinct_return_inliner_min	118 (-1)	-0.84%
conditional_regression_short_circuit_inliner_zero	4,502 (-39)	-0.86%
slices_inliner_zero	3,571 (-31)	-0.86%
array_dynamic_nested_blackbox_input_inliner_min	4,922 (-44)	-0.89%
sha256_var_witness_const_regression_inliner_min	7,723 (-71)	-0.91%
slice_loop_inliner_zero	1,261 (-12)	-0.94%
struct_inputs_inliner_zero	598 (-6)	-0.99%
ram_blowup_regression_inliner_zero	807,236 (-8,205)	-1.01%
simple_shield_inliner_min	2,554 (-27)	-1.05%
brillig_cow_regression_inliner_min	538,912 (-5,711)	-1.05%
brillig_cow_regression_inliner_zero	535,340 (-5,686)	-1.05%
sha2_byte_inliner_zero	71,608 (-761)	-1.05%
ram_blowup_regression_inliner_min	810,963 (-8,736)	-1.07%
conditional_1_inliner_min	5,935 (-64)	-1.07%
array_to_slice_inliner_zero	1,944 (-21)	-1.07%
u128_inliner_max	24,007 (-276)	-1.14%
sha256_brillig_performance_regression_inliner_zero	26,213 (-306)	-1.15%
brillig_arrays_inliner_min	171 (-2)	-1.16%
loop_inliner_min	170 (-2)	-1.16%
slice_loop_inliner_min	1,275 (-15)	-1.16%
simple_2d_array_inliner_min	169 (-2)	-1.17%
array_sort_inliner_min	670 (-8)	-1.18%
sha256_brillig_performance_regression_inliner_min	26,582 (-318)	-1.18%
6_inliner_min	4,816 (-58)	-1.19%
conditional_regression_661_inliner_min	166 (-2)	-1.19%
sha256_inliner_min	12,217 (-149)	-1.20%
struct_inputs_inliner_min	654 (-8)	-1.21%
sha256_inliner_zero	11,290 (-140)	-1.22%
conditional_regression_short_circuit_inliner_min	4,919 (-61)	-1.22%
7_function_inliner_zero	2,411 (-30)	-1.23%
binary_operator_overloading_inliner_min	397 (-5)	-1.24%
regression_4449_inliner_zero	225,507 (-2,870)	-1.26%
conditional_2_inliner_min	156 (-2)	-1.27%
uhashmap_inliner_max	135,778 (-1,742)	-1.27%
fold_complex_outputs_inliner_zero	932 (-12)	-1.27%
brillig_pedersen_inliner_min	920 (-12)	-1.29%
pedersen_check_inliner_min	920 (-12)	-1.29%
generics_inliner_zero	222 (-3)	-1.33%
nested_array_dynamic_inliner_min	3,562 (-51)	-1.41%
nested_array_dynamic_inliner_zero	3,562 (-51)	-1.41%
regression_6674_1_inliner_min	1,030 (-15)	-1.44%
embedded_curve_ops_inliner_zero	402 (-6)	-1.47%
7_function_inliner_min	2,585 (-39)	-1.49%
ecdsa_secp256k1_inliner_zero	7,514 (-117)	-1.53%
regression_4449_inliner_min	265,405 (-4,198)	-1.56%
regression_11294_inliner_min	1,802 (-29)	-1.58%
regression_6734_inliner_min	62 (-1)	-1.59%
array_dynamic_blackbox_input_inliner_zero	20,963 (-348)	-1.63%
nested_array_in_slice_inliner_min	1,712 (-30)	-1.72%
nested_array_in_slice_inliner_zero	1,712 (-30)	-1.72%
debug_logs_inliner_zero	5,351 (-96)	-1.76%
slice_dynamic_index_inliner_min	4,887 (-89)	-1.79%
hint_black_box_inliner_zero	988 (-18)	-1.79%
regression_6674_2_inliner_min	1,032 (-19)	-1.81%
derive_inliner_zero	325 (-6)	-1.81%
regression_bignum_inliner_min	541 (-10)	-1.81%
regression_4124_inliner_min	54 (-1)	-1.82%
tuple_inputs_inliner_min	635 (-12)	-1.85%
tuple_inputs_inliner_zero	635 (-12)	-1.85%
hint_black_box_inliner_min	1,002 (-19)	-1.86%
sha2_byte_inliner_min	87,804 (-1,667)	-1.86%
global_var_regression_simple_inliner_min	210 (-4)	-1.87%
brillig_rc_regression_6123_inliner_min	361 (-7)	-1.90%
slice_regex_inliner_zero	3,981 (-78)	-1.92%
brillig_nested_arrays_inliner_zero	295 (-6)	-1.99%
regression_6674_3_inliner_min	1,966 (-40)	-1.99%
ecdsa_secp256k1_inliner_min	8,045 (-165)	-2.01%
fold_numeric_generic_poseidon_inliner_zero	5,603 (-116)	-2.03%
no_predicates_numeric_generic_poseidon_inliner_zero	5,603 (-116)	-2.03%
fold_numeric_generic_poseidon_inliner_min	5,736 (-122)	-2.08%
no_predicates_numeric_generic_poseidon_inliner_min	5,736 (-122)	-2.08%
higher_order_functions_inliner_zero	1,306 (-28)	-2.10%
generics_inliner_min	321 (-7)	-2.13%
binary_operator_overloading_inliner_zero	225 (-5)	-2.17%
array_dynamic_blackbox_input_inliner_min	21,909 (-489)	-2.18%
nested_arrays_from_brillig_inliner_min	217 (-5)	-2.25%
uhashmap_inliner_zero	171,423 (-3,955)	-2.26%
bench_2_to_17_inliner_min	696,073 (-16,342)	-2.29%
fold_2_to_17_inliner_min	1,323,968 (-31,089)	-2.29%
array_to_slice_inliner_min	2,209 (-52)	-2.30%
fold_2_to_17_inliner_zero	1,286,553 (-31,069)	-2.36%
brillig_conditional_inliner_min	41 (-1)	-2.38%
conditional_regression_547_inliner_min	41 (-1)	-2.38%
slice_regex_inliner_min	8,429 (-208)	-2.41%
hashmap_inliner_zero	72,771 (-1,905)	-2.55%
fold_complex_outputs_inliner_min	1,057 (-28)	-2.58%
poseidon2_inliner_min	850 (-23)	-2.63%
brillig_calls_array_inliner_zero	218 (-6)	-2.68%
trait_impl_base_type_inliner_zero	68 (-2)	-2.86%
strings_inliner_zero	2,038 (-63)	-3.00%
uhashmap_inliner_min	191,220 (-5,941)	-3.01%
slices_inliner_min	4,162 (-130)	-3.03%
derive_inliner_min	596 (-19)	-3.09%
sha256_var_size_regression_inliner_min	21,475 (-713)	-3.21%
sha256_var_size_regression_inliner_zero	20,744 (-689)	-3.21%
fmtstr_with_global_inliner_min	120 (-4)	-3.23%
sha256_var_padding_regression_inliner_zero	223,116 (-7,531)	-3.27%
sha256_var_padding_regression_inliner_min	224,483 (-7,663)	-3.30%
brillig_acir_as_brillig_inliner_min	113 (-4)	-3.42%
u128_inliner_min	46,818 (-1,695)	-3.49%
hashmap_inliner_min	87,224 (-3,198)	-3.54%
references_inliner_zero	380 (-14)	-3.55%
sha256_regression_inliner_zero	149,998 (-5,676)	-3.65%
sha256_regression_inliner_min	151,943 (-5,773)	-3.66%
trait_impl_base_type_inliner_min	253 (-10)	-3.80%
u128_inliner_zero	39,396 (-1,577)	-3.85%
brillig_nested_arrays_inliner_min	469 (-20)	-4.09%
references_inliner_min	615 (-27)	-4.21%
brillig_calls_array_inliner_min	257 (-12)	-4.46%
higher_order_functions_inliner_min	2,188 (-103)	-4.50%
strings_inliner_min	2,758 (-138)	-4.77%
regression_3051_inliner_min	191 (-10)	-4.98%
simple_print_inliner_min	228 (-12)	-5.00%
inline_decompose_hint_brillig_call_inliner_min	260 (-14)	-5.11%
embedded_curve_ops_inliner_min	629 (-37)	-5.56%
brillig_calls_inliner_min	178 (-11)	-5.82%
brillig_calls_conditionals_inliner_min	184 (-14)	-7.07%
brillig_calls_conditionals_inliner_zero	184 (-14)	-7.07%
reference_counts_inliner_min	897 (-73)	-7.53%
debug_logs_inliner_min	9,503 (-814)	-7.89%
reference_counts_inliner_zero	666 (-58)	-8.01%
prelude_inliner_min	216 (-19)	-8.09%

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 871811d	Previous: a9e9850	Ratio
noir-lang_schnorr_	1 s	0 s	+∞
noir-lang_noir_sort_	1 s	0 s	+∞
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	64 s	51 s	1.25

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 40c3b5b	Previous: 49d1b13	Ratio
sha256_regression	1.23 s	0.977 s	1.26
regression_4709	1.04 s	0.845 s	1.23
global_var_regression_entry_points	0.74 s	0.566 s	1.31

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[TomAFrench]

Can you explain a bit more on why we don't place these hoisted constants into the main globals map? We should be able to treat them in exactly the same way.

[vezenovm]

Can you explain a bit more on why we don't place these hoisted constants into the main globals map? We should be able to treat them in exactly the same way.

I decided to do it during Brillig for a few reasons aside this being a Brillig unique operation.

1. To avoid having to alter the globals graph for every function and the cloning cost that comes with it. We would also have to add the ability to mutate the normal function DFG. This feels like a leakage for a Brillig exclusive feature.
2. I also wanted to re-use some of the pre-existing Brillig constant analysis tools.
3. Doing this during our existing Brillig globals generation we could avoid another SSA pass or making a pre-existing complex more complex (as each pass is currently per-function).

Due to the above reasons, I felt we could do this as part of Brillig gen rather than having to alter the pre-existing SSA.

I had considered placing them in the main globals map as well, but ultimately decided to trade-off a new "type" of global and a little extra complexity in Brillig to avoid extra complexity in the SSA passes (most likely it would be constant folding that would be updated) for this Brillig unique feature.