chore: push inlining info code into a submodule #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 11bc7e4 | Previous: 0b6c382 | Ratio |
|---|---|---|---|
noir-lang_sparse_array_ |
2 s |
1 s |
2 |
noir-lang_schnorr_ |
1 s |
0 s |
+∞ |
noir-lang_noir_string_search_ |
1 s |
0 s |
+∞ |
noir-lang_noir_base64_ |
2 s |
1 s |
2 |
noir-lang_mimc_ |
1 s |
0 s |
+∞ |
noir-lang_ec_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
asterite
approved these changes
Feb 5, 2025
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 7, 2025
…/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
TomAFrench
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 7, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265) END_COMMIT_OVERRIDE --------- Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 8, 2025
…-lang/noir#7325) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 9, 2025
…-lang/noir#7325) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 9, 2025
) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 10, 2025
…-lang/noir#7325) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 10, 2025
) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 10, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: avoid stack overflow on many comments in a row (noir-lang/noir#7325) chore: bump noir_bigcurve timeout (noir-lang/noir#7322) fix!: check abi integer input is within signed range (noir-lang/noir#7316) chore: add timeouts to reports CI (noir-lang/noir#7317) fix: allows for infinite brillig loops (noir-lang/noir#7296) feat: simplify `Ord` implementation for arrays (noir-lang/noir#7305) feat: `assert` and `assert_eq` are now expressions (noir-lang/noir#7313) chore: fix memory reports in CI (noir-lang/noir#7311) chore: remove Recoverable (noir-lang/noir#7307) feat: Sync from aztec-packages (noir-lang/noir#7293) chore: reduce number of benchmarking scripts (noir-lang/noir#7285) fix: error on if without else when type mismatch (noir-lang/noir#7302) fix: error on trailing doc comment (noir-lang/noir#7300) fix: always normalize ssa when priting at least one pass (noir-lang/noir#7299) fix: mark field division and modulo as requiring predicate for all necessary types (noir-lang/noir#7290) chore: push inlining info code into a submodule (noir-lang/noir#7266) chore: create a CI action to download nargo and add to path (noir-lang/noir#7281) chore: add sha256 library to test suite (noir-lang/noir#7278) feat: infer lambda parameter types from return type and let type (noir-lang/noir#7267) chore: replace benchmarks on fast test suites with a cut-off (noir-lang/noir#7276) fix(ssa): Unused functions removals post folding constant Brillig calls (noir-lang/noir#7265) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
I'm wanting to separate this code from the inlining logic itself so that we can refactor it in future.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.