Fixes visual for invalid normals

nomnomab · Mar 27, 2023 · a511b1c · a511b1c
1 parent cde4f3d
commit a511b1c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/Runtime/Shapes/Arrow.cs b/Runtime/Shapes/Arrow.cs
@@ -25,7 +25,7 @@ public void Draw(Color color) {
                 headLength = VisualPhysicsSettingsHandler.GetEditorSettings().RegularArrowLength;
             }
 
-            Quaternion rot = direction == Vector3.zero ? Quaternion.identity : Quaternion.LookRotation(direction);
+            Quaternion rot = direction == Vector3.zero || VisualUtils.IsNan(direction) ? Quaternion.identity : Quaternion.LookRotation(direction);
             Vector3 backDir = Vector3.back * headLength;
             Vector3 right = rot * Quaternion.Euler(headAngle, 0, 0) * backDir;
             Vector3 left = rot * Quaternion.Euler(-headAngle, 0, 0) * backDir;

diff --git a/Runtime/Shapes/Circle.cs b/Runtime/Shapes/Circle.cs
@@ -31,7 +31,7 @@ public void Draw(Color color) {
                 cachePosition.y = sin;
                 cachePosition.z = 0;
 
-                Quaternion rot = upDirection == Vector3.zero ? Quaternion.identity : Quaternion.LookRotation(upDirection);
+                Quaternion rot = upDirection == Vector3.zero || VisualUtils.IsNan(upDirection) ? Quaternion.identity : Quaternion.LookRotation(upDirection);
 
                 cachePosition = rot * cachePosition;
                 cachePosition += origin;

diff --git a/Runtime/VisualUtils.cs b/Runtime/VisualUtils.cs
@@ -79,7 +79,7 @@ internal static void DrawCircle(in Vector3 center, in Vector3 upwardDirection, i
 				cachePosition.y = sin;
 				cachePosition.z = 0;
 
-				Quaternion rot = upwardDirection == Vector3.zero ? Quaternion.identity : Quaternion.LookRotation(upwardDirection);
+				Quaternion rot = upwardDirection == Vector3.zero || IsNan(upwardDirection) ? Quaternion.identity : Quaternion.LookRotation(upwardDirection);
 
 				cachePosition = rot * cachePosition;
 				cachePosition += center;
@@ -110,7 +110,7 @@ internal static void DrawNormalCircle(in Vector3 center, in Vector3 upwardDirect
 				cachePosition.y = sin;
 				cachePosition.z = 0;
 
-				Quaternion rot = upwardDirection == Vector3.zero ? Quaternion.identity : Quaternion.LookRotation(upwardDirection);
+				Quaternion rot = upwardDirection == Vector3.zero || IsNan(upwardDirection) ? Quaternion.identity : Quaternion.LookRotation(upwardDirection);
 
 				cachePosition = rot * cachePosition;
 				cachePosition += center + upwardDirection * settings.CircleDistance;
@@ -280,7 +280,7 @@ internal static void DrawArrow(
             arrowHeadLength = VisualPhysicsSettingsHandler.GetEditorSettings().RegularArrowLength;
           }
 
-          Quaternion rot = direction == Vector3.zero ? Quaternion.identity : Quaternion.LookRotation(direction);
+          Quaternion rot = direction == Vector3.zero || IsNan(direction) ? Quaternion.identity : Quaternion.LookRotation(direction);
           Vector3 backDir = Vector3.back * arrowHeadLength;
           Vector3 right = rot * Quaternion.Euler(arrowHeadAngle, 0, 0) * backDir;
           Vector3 left = rot * Quaternion.Euler(-arrowHeadAngle, 0, 0) * backDir;
@@ -310,5 +310,9 @@ internal static void DrawRay(in Vector3 start, in Vector3 direction, in Color co
 			Debug.DrawRay(start, direction, color, drawTime, true);
 #endif
 		}
+
+        internal static bool IsNan(Vector3 vector) {
+            return float.IsNaN(vector.x) || float.IsNaN(vector.y) || float.IsNaN(vector.z);
+        }
     }
 }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "com.nomnom.raycast-visualization",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "displayName": "Nomnom's Raycast Visualization",
   "description": "This asset allows users to view debug visuals for all raycast methods.",
   "unity": "2020.3",