-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ivy as a completion back end option #51
base: master
Are you sure you want to change the base?
Conversation
* smex.el (smex-completion-method): New defcustom. Leave ido as the default. (smex-auto-update): (smex-save-file): (smex-history-length): (smex-prompt-string): (smex-flex-matching): No need to specify group. (smex-map): New defvar. Users can cutomize this in a more robust way. (smex-prepare-ido-bindings): Update. (smex-completing-read): Dispatch on `smex-completion-method'. (smex-initialize): Update. (smex-do-with-selected-item): Dispatch on `smex-completion-method'.
👍 |
Looking forward to this being pulled. |
👍 |
@nonsequitur when this is merged, it's going to be awesome! |
Please merge this, it's excellent! 👍 |
👍 |
Out of curiosity, what does |
@PythonNut counsel misses the command ranking that smex does. For example, with smex, when you call counsel-M-x, you will see the last used command top most in the list. Without smex, you will just get an alphabetically sorted list. |
👍 |
1 similar comment
👍 |
@abo-abo - Is there any particular reason you removed |
it's excellent! suggest merge |
I would be very grateful if this got merged. |
@nonsequitur Hello? |
I just took a (granted fairly quick) look through the gists, inf-ruby and this repo, and I see no activity from @nonsequitur in quite a long time. I don't know if he or she is alive, frankly. We might need to create a fork for this code so we can continue maintaining it. Maybe we shouldn't jump the shark, though. I know nothing of this person. |
@Trevoke Well, @nonsequitur last had activity last July, and this issue was opened in April last year (16 months ago). Looks like the maintainer is somehow not interested in this. |
Consider You can use flx with ivy as per this config |
Sure, I can try it. Where can I find counsel-M-x ? I tried installing On Tue, Aug 30, 2016 at 7:09 PM Jason Milkins notifications@github.com
|
@Trevoke Installing the |
I just tried counsel, but I was disappointed that the default completions when I type |
@kaushalmodi Got it. I ran into an error because I didn't have swiper installed. |
@asmeurer Install smex , counsel-M-x will use it to sort will recent used |
Ah. I had originally left smex enabled, but got some error about it (I'll have to check what it was on my other computer tomorrow, some undefined variable error I think), so I disabled it. |
@Trevoke Yup, installing it using the in-built package manager would have done it automatically for you. From
|
"Symbol's value as variable is void: smex-initialized-p" If I manually execute |
Oh, I see. I've been using the branch from #12. CC @haxney I guess removing smex-initialize in that PR breaks counsel compatibility (and it looks like I already noticed this two years ago smh). |
@nonsequitur please merge this, it's very helpful! |
In my opinion, if you are a ivy user, you should use counsel-M-x instead of smex. |
default.
(smex-auto-update):
(smex-save-file):
(smex-history-length):
(smex-prompt-string):
(smex-flex-matching): No need to specify group.
(smex-map): New defvar. Users can cutomize this in a more robust way.
(smex-prepare-ido-bindings): Update.
(smex-completing-read): Dispatch on
smex-completion-method'. (smex-initialize): Update. (smex-do-with-selected-item): Dispatch on
smex-completion-method'.