-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search facet customizations missing from Knapsack #532
Comments
Deletes the default hyku proper facets and use the adventist proper's settings instead, for feature parity with the original application. Issue: - https://github.com/scientist-softserv/adventist-dl/issues/659
Deletes the default hyku proper facets and use the[ adventist proper's settings](https://github.com/scientist-softserv/adventist-dl/blob/main/app/controllers/catalog_controller.rb#L103-L132) instead, for feature parity with the original application. Issue: - https://github.com/scientist-softserv/adventist-dl/issues/659 # ADVENTIST PROPER ![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/735412a2-7967-4c51-853a-60de8f7d867a) # ADVENTIST KNAPSACK ## BEFORE ![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/176f4e80-38dc-4e36-9895-1666e9f50f62) ## AFTER ![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/9847079c-c96a-4e9f-9b60-8fec040f6589) ## NOTE The carot icon to collapse/expand the facet is broken because of the [bootstrap version change](https://getbootstrap.com/docs/4.1/migration/). I'd argue that should be a separate ticket.
QA Results: Pass ✅
|
knapsack | Production |
---|---|
![]() |
![]() |
Update: this is a known bug in the hyku/hyrax community.
ADL QA: The facets on ADL knapsack staging look exactly as expected! Thank you! |
Adventist Hyku has a customized action in the catalog view / search page where the Source and Type filters appear at the top of the facet menu. Both are automatically open when you visit the catalog or conduct a search. The customizations are not right on Knapsack. On Knapsack, only Source is open automatically, and it doesn't appear at the top of the page. We'd like to see at least the Source field moved to the top of the facets. It is less imperative that the Type field also be moved and set to auto-open. If we have to prioritize fixes, moving the Source field is the most important detail. Reinstating the existing customization for the Type facet is the secondary priority.
https://sdapi.b2.adventistdigitallibrary.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q=
![Image](https://private-user-images.githubusercontent.com/118196520/282910097-55a246dd-b7ae-40f9-bc8f-a4cfe93b9a4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDkyMjcsIm5iZiI6MTczOTQwODkyNywicGF0aCI6Ii8xMTgxOTY1MjAvMjgyOTEwMDk3LTU1YTI0NmRkLWI3YWUtNDBmOS1iYzhmLWE0Y2ZlOTNiOWE0Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMTA4NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMTk1NzZmNzkwNTUzMjBhYjEwZGQzMGRjYzk0YTk3N2M5N2MwNTIwMjkzZWE5ZGI0NTU1YjVmNjUyMTEzYzdlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.R_jYIyabSW9NtIiuMs9HbSFRvxLgjeK2TWo51Cw1Gxk)
https://demo.adventist-knapsack-staging.notch8.cloud/catalog?utf8=%E2%9C%93&locale=en&search_field=all_fields&q=
![Image](https://private-user-images.githubusercontent.com/118196520/282910140-bbed5941-0899-4ac3-b993-9f8328fc7098.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDkyMjcsIm5iZiI6MTczOTQwODkyNywicGF0aCI6Ii8xMTgxOTY1MjAvMjgyOTEwMTQwLWJiZWQ1OTQxLTA4OTktNGFjMy1iOTkzLTlmODMyOGZjNzA5OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMTA4NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jOTM4Mzk2ZDMwNWU4MGE3NDQyMmViOGY4MjVjZWExYWE1ODM0MzUwMTkxYjZkNTRkODczMTE0NzJjMzNhYmZlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.cAz8l2ks5aCHIfe_dFNp8PX-FZFSsYeM4Q7Fzdkw6Vg)
Acceptance Criteria
Testing Instructions
From here
Perform an empty catalog search by clicking "Go"
Verify the facets and order matches Adventist proper's facet list
PS. If you see a facet category missing, it may be because we don't have any data that uses such property. Create a new work manually and fill in all the details.
NOTE
The carot icon to collapse/expand the facet (seen in adventist proper) is broken because of the bootstrap version change. I'd argue that should be fixed in a separate ticket.
The text was updated successfully, but these errors were encountered: