Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search facet customizations missing from Knapsack #532

Closed
1 task
Tracked by #113
KatharineV opened this issue Nov 14, 2023 · 2 comments
Closed
1 task
Tracked by #113

Search facet customizations missing from Knapsack #532

KatharineV opened this issue Nov 14, 2023 · 2 comments
Assignees
Labels
bug something isn't working Knapsack Upgrade

Comments

@KatharineV
Copy link
Collaborator

KatharineV commented Nov 14, 2023

Adventist Hyku has a customized action in the catalog view / search page where the Source and Type filters appear at the top of the facet menu. Both are automatically open when you visit the catalog or conduct a search. The customizations are not right on Knapsack. On Knapsack, only Source is open automatically, and it doesn't appear at the top of the page. We'd like to see at least the Source field moved to the top of the facets. It is less imperative that the Type field also be moved and set to auto-open. If we have to prioritize fixes, moving the Source field is the most important detail. Reinstating the existing customization for the Type facet is the secondary priority.

https://sdapi.b2.adventistdigitallibrary.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q=
Image

https://demo.adventist-knapsack-staging.notch8.cloud/catalog?utf8=%E2%9C%93&locale=en&search_field=all_fields&q=
Image

Acceptance Criteria

  • Adventist Knapsack should match the category and order of Adventist's facet list. (The facet list is the sidebar of the catalog search results page.) See PR for more details.

Testing Instructions

From here
Perform an empty catalog search by clicking "Go"
Verify the facets and order matches Adventist proper's facet list

PS. If you see a facet category missing, it may be because we don't have any data that uses such property. Create a new work manually and fill in all the details.

NOTE

The carot icon to collapse/expand the facet (seen in adventist proper) is broken because of the bootstrap version change. I'd argue that should be fixed in a separate ticket.

@KatharineV KatharineV added bug something isn't working Knapsack Upgrade labels Nov 14, 2023
ShanaLMoore referenced this issue Nov 21, 2023
Deletes the default hyku proper facets and use the adventist proper's settings instead, for feature parity with the original application.

Issue:
- https://github.com/scientist-softserv/adventist-dl/issues/659
ShanaLMoore referenced this issue Nov 22, 2023
Deletes the default hyku proper facets and use the[ adventist proper's
settings](https://github.com/scientist-softserv/adventist-dl/blob/main/app/controllers/catalog_controller.rb#L103-L132)
instead, for feature parity with the original application.

Issue:
- https://github.com/scientist-softserv/adventist-dl/issues/659

# ADVENTIST PROPER


![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/735412a2-7967-4c51-853a-60de8f7d867a)

# ADVENTIST KNAPSACK
## BEFORE


![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/176f4e80-38dc-4e36-9895-1666e9f50f62)

## AFTER

![image](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/9847079c-c96a-4e9f-9b60-8fec040f6589)

## NOTE

The carot icon to collapse/expand the facet is broken because of the
[bootstrap version
change](https://getbootstrap.com/docs/4.1/migration/). I'd argue that
should be a separate ticket.
@ShanaLMoore
Copy link

ShanaLMoore commented Dec 1, 2023

QA Results: Pass ✅ ⚠️

Tested on: Staging

knapsack Production
image image

⚠️ Note: I consider this a pass. The location facet is not available because there's no data with a location value. In knapsack staging this field does not populate. I'd consider this to be a separate bug ticket. I'd added the location facet check as an acceptance criteria on that ticket.

Update: this is a known bug in the hyku/hyrax community.

image

@KatharineV
Copy link
Collaborator Author

ADL QA: The facets on ADL knapsack staging look exactly as expected! Thank you!

@kirkkwang kirkkwang transferred this issue from notch8/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working Knapsack Upgrade
Projects
Archived in project
Development

No branches or pull requests

2 participants