🎁 make facet options match adventist-dl proper #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletes the default hyku proper facets and use the adventist proper's settings instead, for feature parity with the original application. Issue: - https://github.com/scientist-softserv/adventist-dl/issues/659
ShanaLMoore
commented
Nov 21, 2023
Previously this was hardcoded but what if Hyku changes? This commit implements a dynamic method to delete hyku's default settings.
1 task
ShanaLMoore
commented
Nov 21, 2023
kirkkwang
approved these changes
Nov 21, 2023
Ruby has a method called #clear that will clear the hash, which is basically what the method was previously doing but much more efficiently.
jeremyf
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes the default hyku proper facets and use the adventist proper's settings instead, for feature parity with the original application.
Issue:
ADVENTIST PROPER
ADVENTIST KNAPSACK
BEFORE
AFTER
NOTE
The carot icon to collapse/expand the facet is broken because of the bootstrap version change. I'd argue that should be a separate ticket.