Fixes for resplit #385
Merged
Fixes for resplit #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
approved these changes
Feb 7, 2025
This commit does two things: - moves an fix to child_works_from_pdf_job from the Adventist repo for derivative rodeo splitter. - adds a fix to the Valkyrie adapter to ensure that the member relationships are broken prior to deleting the child works. This change prevents numerous jobs from failing due to testing the migration status of the child works which may no longer exist.
laritakr
force-pushed
the
more-fixes-for-resplit
branch
from
124bb55 to
621fdb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit does two things:
Refs notch8/adventist_knapsack#914
Expected Behavior Before Changes
PDF re-splitting triggers numerous migration jobs for child works in process of being deleted.