🐛 Hide table that doesn't display anything #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This table seems to not display anything but it takes up space and makes the page scroll horizontally on the dashboard. We're very specifically targeting the table and hiding it.
ShanaLMoore
approved these changes
Feb 12, 2024
The words looked a little too awkward when they were justified. This commit will remove that from the catalog search page on the DC view theme.
ShanaLMoore
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table seems to not display anything but it takes up space and makes the page scroll horizontally on the dashboard. We're very specifically targeting the table and hiding it.
The words looked a little too awkward when they were justified. This commit will remove that from the catalog search page on the DC view theme.
Story
Ref:
Expected Behavior Before Changes
There was horizontal scrolling on the dashboard page in mobile widths.
The text on the catalog search results page was justified in mobile widths.
Expected Behavior After Changes
A none displaying table is set to
display: none;on the dashboard to prevent horizontal scrolling.The is no longer justify aligned on the catalog search results page on mobile widths.
Screenshots / Video
Before
After
