Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connectionset from analyzer #8

Closed
wants to merge 8 commits into from
Closed

Move connectionset from analyzer #8

wants to merge 8 commits into from

Conversation

elazarg
Copy link
Member

@elazarg elazarg commented Mar 3, 2024

Temporarily this adds a dependency on the synthesizer. It should be changed soon.

@elazarg elazarg requested a review from adisos March 3, 2024 13:21
@elazarg elazarg changed the title move connectionset from analyzer Move connectionset from analyzer Mar 3, 2024
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also move statefuleness to models?

@elazarg
Copy link
Member Author

elazarg commented Mar 3, 2024

The CI linter required multiple changes to stateful_test for some reason. The command line linter did not warn about most of them.

@elazarg
Copy link
Member Author

elazarg commented Mar 3, 2024

Should also move statefuleness to models?

Done

@elazarg elazarg requested a review from adisos March 3, 2024 14:22
Signed-off-by: Elazar Gershuni <elazarg@ibm.com>
@elazarg elazarg marked this pull request as draft March 3, 2024 14:58
@elazarg elazarg marked this pull request as ready for review March 6, 2024 11:59
@elazarg elazarg requested a review from adisos March 6, 2024 11:59
@elazarg
Copy link
Member Author

elazarg commented Mar 6, 2024

Moved some parts from synthesis here, and removed the dependency on the synthesis JSON format.

@elazarg
Copy link
Member Author

elazarg commented Mar 6, 2024

Replaced by #10

@elazarg elazarg closed this Mar 6, 2024
@elazarg elazarg deleted the connectionset branch March 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants