Service to connection set (#6) #16
haim-kermanyAnnotations
10 errors
|
golangci-lint:
pkg/model/dfw/category.go#L125
paramTypeCombine: func(src, dst []*endpoints.VM, conn *connection.Set, action string, direction string, origRule *collector.Rule) could be replaced with func(src, dst []*endpoints.VM, conn *connection.Set, action, direction string, origRule *collector.Rule) (gocritic)
|
|
golangci-lint:
pkg/model/dfw/dfw.go#L73
paramTypeCombine: func(src, dst []*endpoints.VM, conn *connection.Set, categoryStr string, actionStr string, direction string, origRule *collector.Rule) could be replaced with func(src, dst []*endpoints.VM, conn *connection.Set, categoryStr, actionStr, direction string, origRule *collector.Rule) (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L211
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L80
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L129
hugeParam: rule is heavy (520 bytes); consider passing it by pointer (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L150
hugeParam: rule is heavy (520 bytes); consider passing it by pointer (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L60
rangeValCopy: each iteration copies 216 bytes (consider pointers or indexing) (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L73
rangeValCopy: each iteration copies 304 bytes (consider pointers or indexing) (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L75
rangeValCopy: each iteration copies 464 bytes (consider pointers or indexing) (gocritic)
|
|
golangci-lint:
pkg/model/parser.go#L86
rangeValCopy: each iteration copies 520 bytes (consider pointers or indexing) (gocritic)
|