one In/outbound list - to set proirity in right order

[haim-kermany]

No description provided.

[adisos]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml policies admin_policy_8 and admin_policy_9 are identical?

[haim-kermany]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

[adisos]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

can improve the code to avoid generating identical policies? (can be in separate issue/PR)

[haim-kermany]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

can improve the code to avoid generating identical policies? (can be in separate issue/PR)

I think it should be partof Shiri's optimization, will open an issue for her

[adisos]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

• can rename the tests to avoid this convention?
• I still don't follow entirely the tests, their naming are confusing.
  currenrtly there are few main unit tests in this file TestPreprocessing , TestCollectAndConvertToAbstract , TestConvertToAbsract, and TestTmpExpr.
  no test name indicates the e2e translation to k8s policies...
  the functionalities of testing the abstract model, vs comparing the expected policies from e2e generation, should better be separated .

[adisos]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

can improve the code to avoid generating identical policies? (can be in separate issue/PR)

I think it should be partof Shiri's optimization, will open an issue for her

actually they are not identical, one is egress and the other is ingress.
could be merged in one policy, but this can be left to a separate issue.

[haim-kermany]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

* can rename the tests to avoid this convention?

* I still don't follow entirely the tests, their naming are confusing.
  currenrtly there are few main unit tests in this file `TestPreprocessing`  , `TestCollectAndConvertToAbstract` , `TestConvertToAbsract`, and `TestTmpExpr`.
  no test name indicates the e2e translation to k8s policies...
  the functionalities of testing the abstract model, vs comparing the expected policies from e2e generation, should better be separated .

{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.MinCategory(),
	noHint:                false,
},
{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.AppCategoty,
	noHint:                false,
},

I thought about renaming the test, but It will not guarantee duplicating tests in the future

[adisos]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

* can rename the tests to avoid this convention?

* I still don't follow entirely the tests, their naming are confusing.
  currenrtly there are few main unit tests in this file `TestPreprocessing`  , `TestCollectAndConvertToAbstract` , `TestConvertToAbsract`, and `TestTmpExpr`.
  no test name indicates the e2e translation to k8s policies...
  the functionalities of testing the abstract model, vs comparing the expected policies from e2e generation, should better be separated .

{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.MinCategory(),
	noHint:                false,
},
{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.AppCategoty,
	noHint:                false,
},

I thought about renaming the test, but It will not guarantee duplicating tests in the future

can add a method that validates that test names are not duplicated

[haim-kermany]

started reviewing the examples first, few questions:

1. what is the convention of `tests_expected_output/<example_name>_<true/false>_0 ?
   how can one associate the original example this refers to? and how it should be run? (from cli?)

2. in `pkg/synthesis/tests_expected_output/k8s_resources/ExampleHogwarts_false_4/policies.yaml` policies admin_policy_8  and admin_policy_9  are identical?

1. Unfortunately, go allow two tests with the same name. to create a different directory for each test, I uses other test flags for naming the output dir:
   baseName := fmt.Sprintf("%s_%t_%d", synTest.name, synTest.noHint, synTest.allowOnlyFromCategory)
2. yes, there are two rules - one inbound and one outbound. they are both translated to to two k8s policies, and the translation is identical

* can rename the tests to avoid this convention?

* I still don't follow entirely the tests, their naming are confusing.
  currenrtly there are few main unit tests in this file `TestPreprocessing`  , `TestCollectAndConvertToAbstract` , `TestConvertToAbsract`, and `TestTmpExpr`.
  no test name indicates the e2e translation to k8s policies...
  the functionalities of testing the abstract model, vs comparing the expected policies from e2e generation, should better be separated .

{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.MinCategory(),
	noHint:                false,
},
{
	name:                  "ExampleHogwarts",
	exData:                tests.ExampleHogwarts,
	allowOnlyFromCategory: collector.AppCategoty,
	noHint:                false,
},

I thought about renaming the test, but It will not guarantee duplicating tests in the future

can add a method that validates that test names are not duplicated

yes, we can.
please notice that:

1. this PR is not about thynsesis_test.go.
2. thynsesis_test.go was created and designed by Shiri, she likes the convention of using the same name to different tests.

[adisos]

ok, let's keep the test re-org for issue #129.