-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print abstract policy to log #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
maybe for a separate issue, ran with pkg/collector/data/json/Example1.json
and got log messages that are not clear:
INFO Expression must not be nil and must be of size at least 1
the abstract model is printed this way:
INFO abstract model
~~~~~~~~~~~~~~
category: Application
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
symbolic inbound rules:
0. action: allow paths: src: (group = frontend) dst: (group = backend) conn: TCP dst-ports: 445
1. action: deny paths: src: (*) dst: (*) conn: All Connections
symbolic outbound rules:
0. action: allow paths: src: (group = frontend) dst: (group = backend) conn: TCP dst-ports: 445
1. action: deny paths: src: (*) dst: (*) conn: All Connections
another comment, maybe for a separate issue - consider printing in table format (similar to connectivity output, input rules of DFW, etc... there is a func in common
pkg to use that - GenerateTableString
).
please op
Please open a separate issue for the table |
do you want to fix the issue about the unclear log message in this PR? (already opened an issue about other unclear log messages). |
fixed (" INFO Expression must not be nil and must be of size at least 1" rewritten) |
getting many duplications of this warning in the log:
can fix here or open a separate issue to avoid these duplications. I'm having problem in reproducing it; Lets open another issue. |
Co-authored-by: Adi Sosnovich <82078442+adisos@users.noreply.github.com>
No description provided.