Skip to content

Commit

Permalink
fix(gradle): log gradlew output for verbose (#29966)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
xiongemi authored Feb 13, 2025
1 parent 8b1cd48 commit b8ee838
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions packages/gradle/src/utils/get-project-report-lines.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AggregateCreateNodesError, logger } from '@nx/devkit';
import { AggregateCreateNodesError, logger, output } from '@nx/devkit';
import { execGradleAsync } from './exec-gradle';
import { existsSync } from 'fs';
import { dirname, join } from 'path';
Expand Down Expand Up @@ -36,6 +36,7 @@ export async function getProjectReportLines(
try {
projectReportBuffer = await execGradleAsync(gradlewFile, [
'projectReportAll',
process.env.NX_VERBOSE_LOGGING === 'true' ? '--info' : '',
]);
} catch (e: Buffer | Error | any) {
if (e.toString()?.includes('ERROR: JAVA_HOME')) {
Expand Down Expand Up @@ -85,8 +86,17 @@ export async function getProjectReportLines(
);
}
}
return projectReportBuffer
const projectReportLines = projectReportBuffer
.toString()
.split(newLineSeparator)
.filter((line) => line.trim() !== '');

if (process.env.NX_VERBOSE_LOGGING === 'true') {
output.log({
title: `Successfully ran projectReportAll or projectRerport task using ${gradlewFile}`,
bodyLines: projectReportLines,
});
}

return projectReportLines;
}

0 comments on commit b8ee838

Please sign in to comment.